Skip to content

Conversation

tangenta
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #56797

Problem Summary:

We may have multiple domains in unit test. It is better not to use global variables as soon as possible.

What changed and how does it work?

Change global variable recordMap to local one.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 23, 2024
Copy link

tiprow bot commented Oct 23, 2024

Hi @tangenta. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 23, 2024
Copy link

ti-chi-bot bot commented Oct 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, nolouch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 23, 2024
Copy link

ti-chi-bot bot commented Oct 23, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-23 06:31:49.397863878 +0000 UTC m=+419110.094654505: ☑️ agreed by hawkingrei.
  • 2024-10-23 06:40:18.257557395 +0000 UTC m=+419618.954348021: ☑️ agreed by nolouch.

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.4418%. Comparing base (ba5823b) to head (2d4425d).
Report is 2 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #56798         +/-   ##
=================================================
- Coverage   73.3727%   56.4418%   -16.9310%     
=================================================
  Files          1635       1761        +126     
  Lines        452770     632423     +179653     
=================================================
+ Hits         332210     356951      +24741     
- Misses       100208     251348     +151140     
- Partials      20352      24124       +3772     
Flag Coverage Δ
integration 37.1452% <100.0000%> (?)
unit 72.5972% <100.0000%> (+0.1046%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 52.7299% <ø> (+6.7068%) ⬆️

@ti-chi-bot ti-chi-bot bot merged commit 7599574 into pingcap:master Oct 23, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unstable test TestAnalyzeColumnsWithVirtualColumnIndex
3 participants