disttask: add index error——global task manager is not initialized

[yao-2110]

Bug Report

1. Minimal reproduce step (Required)

use test;

CREATE TABLE `t` (
  `id` varchar(100) NOT NULL
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_bin;

set global tidb_enable_dist_task=OFF;

alter table t add index id(id);

set global tidb_enable_dist_task=ON;

drop index id on t;

alter table t add index id(id);

2. What did you expect to see? (Required)

no error.

3. What did you see instead (Required)

mysql> use test;
Database changed

mysql> CREATE TABLE `t` (
    ->   `id` varchar(100) NOT NULL
    -> ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_bin;
Query OK, 0 rows affected (0.02 sec)

mysql> set global tidb_enable_dist_task=OFF;
Query OK, 0 rows affected (0.02 sec)
 
mysql> alter table t add index id(id);
Query OK, 0 rows affected (0.02 sec)

mysql>set global tidb_enable_dist_task=ON;
Query OK, 0 rows affected (0.02 sec)

mysql>drop index id on t;
Query OK, 0 rows affected (0.02 sec)

mysql>alter table t add index id(id);Query OK, 0 rows affected (1.02 sec)
Query OK, 0 rows affected (0.02 sec)

mysql> set global tidb_enable_dist_task=ON;
Query OK, 0 rows affected (0.02 sec)

mysql> drop index id on t;
Query OK, 0 rows affected (0.52 sec)

mysql> alter table t add index id(id);
ERROR 1105 (HY000): global task manager is not initialized

4. What is your TiDB version? (Required)

mysql> select tidb_version();
+----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| tidb_version()                                                                                                                                                                                                                                                 |
+----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Release Version: v7.4.0
Edition: Community
Git Commit Hash: 38cb4f3312be9199a983c0ef282d2ea2e28a7824
Git Branch: heads/refs/tags/v7.4.0
UTC Build Time: 2023-10-10 14:18:50
GoVersion: go1.21.1
Race Enabled: false
Check Table Before Drop: false
Store: tikv |
+----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
1 row in set (0.00 sec)

replayer_addindex_t.zip

2023-10-12 18:40:47 (UTC+08:00)TiDB 172.21.16.17:4000[conn.go:1099] ["command dispatched failed"] [conn=2891974120] [session_alias=] [connInfo="id:2891974120, addr:172.21.0.143:47702 status:10, collation:utf8mb4_general_ci, user:root"] [command=Query] [status="inTxn:0, autocommit:1"] [sql="alter table t add index id(id)"] [txn_mode=PESSIMISTIC] [timestamp=444886481836703746] [err="[ddl:-1]global task manager is not initialized\ngithub.com/pingcap/errors.AddStack\n\t/go/pkg/mod/github.com/pingcap/errors@v0.11.5-0.20221009092201-b66cddb77c32/errors.go:174\ngithub.com/pingcap/errors.Trace\n\t/go/pkg/mod/github.com/pingcap/errors@v0.11.5-0.20221009092201-b66cddb77c32/juju_adaptor.go:15\ngithub.com/pingcap/tidb/ddl.(*ddl).DoDDLJob\n\t/home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/ddl/ddl.go:1197\ngithub.com/pingcap/tidb/ddl.(*ddl).createIndex\n\t/home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/ddl/ddl_api.go:7328\ngithub.com/pingcap/tidb/ddl.(*ddl).AlterTable\n\t/home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/ddl/ddl_api.go:3711\ngithub.com/pingcap/tidb/executor.(*DDLExec).executeAlterTable\n\t/home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/executor/ddl.go:385\ngithub.com/pingcap/tidb/executor.(*DDLExec).Next\n\t/home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/executor/ddl.go:149\ngithub.com/pingcap/tidb/executor/internal/exec.Next\n\t/home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/executor/internal/exec/executor.go:283\ngithub.com/pingcap/tidb/executor.(*ExecStmt).next\n\t/home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/executor/adapter.go:1223\ngithub.com/pingcap/tidb/executor.(*ExecStmt).handleNoDelayExecutor\n\t/home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/executor/adapter.go:968\ngithub.com/pingcap/tidb/executor.(*ExecStmt).handleNoDelay\n\t/home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/executor/adapter.go:794\ngithub.com/pingcap/tidb/executor.(*ExecStmt).Exec\n\t/home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/executor/adapter.go:575\ngithub.com/pingcap/tidb/session.runStmt\n\t/home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/session/session.go:2422\ngithub.com/pingcap/tidb/session.(*session).ExecuteStmt\n\t/home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/session/session.go:2272\ngithub.com/pingcap/tidb/server.(*TiDBContext).ExecuteStmt\n\t/home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/server/driver_tidb.go:292\ngithub.com/pingcap/tidb/server.(*clientConn).handleStmt\n\t/home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/server/conn.go:2011\ngithub.com/pingcap/tidb/server.(*clientConn).handleQuery\n\t/home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/server/conn.go:1802\ngithub.com/pingcap/tidb/server.(*clientConn).dispatch\n\t/home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/server/conn.go:1289\ngithub.com/pingcap/tidb/server.(*clientConn).Run\n\t/home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/server/conn.go:1068\ngithub.com/pingcap/tidb/server.(*Server).onConn\n\t/home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/server/server.go:700\nruntime.goexit\n\t/usr/local/go/src/runtime/asm_amd64.s:1650"]

[yao-2110]

2023-10-12 17:47:29 (UTC+08:00)TiDB 172.21.16.10:4000[domain.go:1483] ["dist task scheduler failed"] [error="[schema:1146]Table 'mysql.dist_framework_meta' doesn't exist"]
2023-10-12 17:47:29 (UTC+08:00)TiDB 172.21.16.10:4000[wait_group_wrapper.go:137] ["background process exited"] [source=domain] [process=distTaskFrameworkLoop]

I upgraded the cluster from 7.3 to 7.4 using Tiup。But table 'mysql.dist_framework_meta' doesn't exist.

[yao-2110]

tidb/session/bootstrap.go

Line 604 in 0fd232f

CreateDistFrameworkMeta = `CREATE TABLE IF NOT EXISTS mysql.dist_framework_meta (

CREATE TABLE IF NOT EXISTS mysql.dist_framework_meta (
        host VARCHAR(100) NOT NULL PRIMARY KEY,
        role VARCHAR(64),
        keyspace_id bigint(8) NOT NULL DEFAULT -1);

then

tiup cluster restart [cluster-name] -R tidb

Run add index again successfully.

[yao-2110]

https://github.com/pingcap/tidb/blob/v7.4.0/session/bootstrap.go#L2829

When the version is upgraded, only the mysql.tidb_global_task_history table is created.

[ywqzzy]

/remove-label may-affects-5.3 may-affects-5.4 may-affects-6.1 may-affects-6.5 may-affects-7.1

[ywqzzy]

/label affects-7.5 affects-7.4