-
Notifications
You must be signed in to change notification settings - Fork 6k
Labels
affects-7.1This bug affects the 7.1.x(LTS) versions.This bug affects the 7.1.x(LTS) versions.affects-7.5This bug affects the 7.5.x(LTS) versions.This bug affects the 7.5.x(LTS) versions.sig/sql-infraSIG: SQL InfraSIG: SQL Infratype/enhancementThe issue or PR belongs to an enhancement.The issue or PR belongs to an enhancement.
Description
Enhancement
Some functions about LDAP
don't have timeout mechanism (e.g. StartTLS
), therefore, the RLock
of it cannot be released until the upstream returns.
I'd like to address the following enhancement:
- Don't include any network / IO in the
RLock
. AnRLock
in golang can block theLock
, and a pending write lock will blocks all otherRLock
, which will make the things much worse. - Add timeout mechanism for
LDAP
functions. - Add metrics for them.
Metadata
Metadata
Assignees
Labels
affects-7.1This bug affects the 7.1.x(LTS) versions.This bug affects the 7.1.x(LTS) versions.affects-7.5This bug affects the 7.5.x(LTS) versions.This bug affects the 7.5.x(LTS) versions.sig/sql-infraSIG: SQL InfraSIG: SQL Infratype/enhancementThe issue or PR belongs to an enhancement.The issue or PR belongs to an enhancement.