Skip to content

Duplicate attributes in BR json log for pitr #53645

@dveeden

Description

@dveeden

Bug Report

The "restore log success summary" looks like this in the output of br:

[2024/05/29 08:40:10.537 +02:00] [INFO] [collector.go:77] ["restore log success summary"] [total-take=3.607614879s] [restore-from=450091587356590086] [restore-to=450091627315200000] [restore-from="2024-05-29 08:12:27.57 +0200"] [restore-to="2024-05-29 08:15:00 +0200"] [total-kv-count=2] [skipped-kv-count-by-checkpoint=0] [total-size=191B] [skipped-size-by-checkpoint=0B] [average-speed=52.94B/s]

And when using --log-format json this looks like this:

{"level":"INFO","time":"2024/05/29 08:43:01.784 +02:00","caller":"collector.go:78","message":"restore log success summary","total-take":"3.595453335s","restore-from":450091587356590086,"restore-to":450091627315200000,"restore-from":"2024-05-29 08:12:27.57 +0200","restore-to":"2024-05-29 08:15:00 +0200","total-kv-count":2,"skipped-kv-count-by-checkpoint":0,"total-size":"191B","skipped-size-by-checkpoint":"0B","average-speed":"53.12B/s"}

When using jq to do display/filtering/etc it looks like this:

{
  "level": "INFO",
  "time": "2024/05/29 08:43:01.784 +02:00",
  "caller": "collector.go:78",
  "message": "restore log success summary",
  "total-take": "3.595453335s",
  "restore-from": "2024-05-29 08:12:27.57 +0200",
  "restore-to": "2024-05-29 08:15:00 +0200",
  "total-kv-count": 2,
  "skipped-kv-count-by-checkpoint": 0,
  "total-size": "191B",
  "skipped-size-by-checkpoint": "0B",
  "average-speed": "53.12B/s"
}

The problem here is that there are duplicate keys in this output for restore-to and restore-from. Once with the TS and once with the human readable timestamp.

Suggestion:
Rename one of these for each group to avoid duplicate attributes.

Metadata

Metadata

Assignees

No one assigned

    Labels

    component/brThis issue is related to BR of TiDB.severity/minortype/bugThe issue is confirmed as a bug.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions