Skip to content

seems writeBufs.IndexValsBuf in TableCommon.addIndices is not reused. #54698

@lcwangchao

Description

@lcwangchao

Enhancement

See:

indexVals, err := v.FetchValues(r, indexVals)

The indexVals is assigned using := that makes it a new variable and shadows the outside declaration.

image

writeBufs.IndexValsBuf is always nil and the []types.Datum will be allocated every time.

Metadata

Metadata

Assignees

No one assigned

    Labels

    type/enhancementThe issue or PR belongs to an enhancement.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions