-
Notifications
You must be signed in to change notification settings - Fork 6k
Closed
Labels
affects-7.5This bug affects the 7.5.x(LTS) versions.This bug affects the 7.5.x(LTS) versions.affects-8.1This bug affects the 8.1.x(LTS) versions.This bug affects the 8.1.x(LTS) versions.affects-8.5This bug affects the 8.5.x(LTS) versions.This bug affects the 8.5.x(LTS) versions.sig/plannerSIG: PlannerSIG: Plannertype/enhancementThe issue or PR belongs to an enhancement.The issue or PR belongs to an enhancement.
Description
Enhancement
Some logs info shows the message which meaning can be directly displayed by default behavior. So we don't need to addition log it.
For example, the runtime filter could not support the hash join which is running in TiDB. This is the default behavior of Runtime Filter. So when the planner meet the TiDB hash join, we don't need to log it by "RF only support TiFlash compute engine while storage type of hash join node is not TiFlash"
func (generator *RuntimeFilterGenerator) generateRuntimeFilterInterval(hashJoinPlan *PhysicalHashJoin) {
// precondition: the storage type of hash join must be TiFlash
if hashJoinPlan.storeTp != kv.TiFlash {
logutil.BgLogger().Warn("RF only support TiFlash compute engine while storage type of hash join node is not TiFlash",
zap.Int("PhysicalHashJoinId", hashJoinPlan.ID()),
zap.String("StoreTP", hashJoinPlan.storeTp.Name()))
return
}
Metadata
Metadata
Assignees
Labels
affects-7.5This bug affects the 7.5.x(LTS) versions.This bug affects the 7.5.x(LTS) versions.affects-8.1This bug affects the 8.1.x(LTS) versions.This bug affects the 8.1.x(LTS) versions.affects-8.5This bug affects the 8.5.x(LTS) versions.This bug affects the 8.5.x(LTS) versions.sig/plannerSIG: PlannerSIG: Plannertype/enhancementThe issue or PR belongs to an enhancement.The issue or PR belongs to an enhancement.