Skip to content

Runtime Filter: Reduce useless logs #57625

@elsa0520

Description

@elsa0520

Enhancement

Some logs info shows the message which meaning can be directly displayed by default behavior. So we don't need to addition log it.

For example, the runtime filter could not support the hash join which is running in TiDB. This is the default behavior of Runtime Filter. So when the planner meet the TiDB hash join, we don't need to log it by "RF only support TiFlash compute engine while storage type of hash join node is not TiFlash"

func (generator *RuntimeFilterGenerator) generateRuntimeFilterInterval(hashJoinPlan *PhysicalHashJoin) {
	// precondition: the storage type of hash join must be TiFlash
	if hashJoinPlan.storeTp != kv.TiFlash {
		logutil.BgLogger().Warn("RF only support TiFlash compute engine while storage type of hash join node is not TiFlash",
			zap.Int("PhysicalHashJoinId", hashJoinPlan.ID()),
			zap.String("StoreTP", hashJoinPlan.storeTp.Name()))
		return
	}

Metadata

Metadata

Assignees

No one assigned

    Labels

    affects-7.5This bug affects the 7.5.x(LTS) versions.affects-8.1This bug affects the 8.1.x(LTS) versions.affects-8.5This bug affects the 8.5.x(LTS) versions.sig/plannerSIG: Plannertype/enhancementThe issue or PR belongs to an enhancement.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions