Skip to content

when ttl delete limiter interrupted, it's better to retry failed rows #58205

@lcwangchao

Description

@lcwangchao

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

  1. start a TTL job, but set @@global.tidb_ttl_delete_rate_limit to a small value.
  2. shrink the delete worker by setting @@global.tidb_ttl_delete_worker_count

2. What did you expect to see? (Required)

We should reduce the error rows in this scene.

3. What did you see instead (Required)

You can see some error rows because the code:

if err = globalDelRateLimiter.Wait(ctx); err != nil {
t.statistics.IncErrorRows(len(delBatch))
return
}

The waiting rows are marked as error directly. It's better to retry them.

4. What is your TiDB version? (Required)

Metadata

Metadata

Assignees

No one assigned

    Labels

    affects-7.1This bug affects the 7.1.x(LTS) versions.affects-7.5This bug affects the 7.5.x(LTS) versions.affects-8.1This bug affects the 8.1.x(LTS) versions.affects-8.5This bug affects the 8.5.x(LTS) versions.severity/minorsig/sql-infraSIG: SQL Infratype/bugThe issue is confirmed as a bug.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions