ADD COLUMN makes UPDATE fail for DATE column with non-allowed default '0000-00-00'

[mjonss]

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

create table t (id bigint primary key, name varchar(20));
alter table t add column d date not null;
update t set name = 'x';

2. What did you expect to see? (Required)

No error

3. What did you see instead (Required)

ERROR 1292 (22007) at line 5: Incorrect date value: '0000-00-00'

But only if the column was added through ALTER TABLE, not if the column d was included in the CREATE TABLE.

4. What is your TiDB version? (Required)

release-6.5

tidb_version(): Release Version: v6.6.0-alpha-146-g5eea731db0-dirty
Edition: Community
Git Commit Hash: 5eea731db0712f1c8a90a3a81e7881da4e400f95
Git Branch: HEAD
UTC Build Time: 2025-01-20 17:22:35
GoVersion: %!s(bool=false)
Race Enabled: 6.2.0-alpha
TiKV Min Version: %!s(bool=false)
Check Table Before Drop: unistore

[mjonss]

git bisect shows #40326 as fixing the issue, more exactly the change in table/column.go ignoring casting the default value if datetime or timestamp, which this PR changed to also ignore it for date which fixes this issue as well.

[YangKeao]

Close as it has been fixed in #59049 for release 6.5 and #40326 for later versions.