-
Notifications
You must be signed in to change notification settings - Fork 6k
Closed
Labels
good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Description
In #7117 we add a framework to validate input when set system variables, but not all system variables are checked in that pr because there are too much of them. We should complete these checks step by step.
What to do:
- Find out the specific limitation in MySQL system variable reference
- Add related validation in method
ValidateSetSystemVar
insessionctx/variable/varsutil.go
- Add related tests in
executor/set_test.go
Notes:
- Details about MySQL system variables can be found here
- executor,sessionctx: Add correctness for more system variables #7196 be be referd as an example.
- System variables with
ScopeNone
scope need not be checked because they can't be changed dynamically.
Metadata
Metadata
Assignees
Labels
good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.