Skip to content

statistics: fix the unexpected estimation error on full sampling #24623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
May 26, 2021
Merged

statistics: fix the unexpected estimation error on full sampling #24623

merged 16 commits into from
May 26, 2021

Conversation

winoros
Copy link
Member

@winoros winoros commented May 13, 2021

What problem does this PR solve?

Problem Summary:

This pr fixes the following problems for full sampling

  • When init the stats, the topn cannot be inited since there's no cmsketch.
  • When checking OutOfRang, doesn't check whether the value is in TopN, it will go wrong.
  • When loading stats from json, the topn is not loaded since the cmsketch is nil.

What is changed and how it works?

Proposal: xxx

What's Changed:

Fix the three problems.

Check List

Tests

  • Unit test(to be added)

Release note

  • No release note

@winoros winoros added the sig/planner SIG: Planner label May 13, 2021
@winoros winoros requested a review from a team as a code owner May 13, 2021 08:10
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 13, 2021
time-and-fate
time-and-fate reviewed May 14, 2021
View reviewed changes
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 14, 2021
eurekaka
eurekaka approved these changes May 25, 2021
View reviewed changes
Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 25, 2021
time-and-fate
time-and-fate approved these changes May 25, 2021
View reviewed changes
Copy link
Member

@time-and-fate time-and-fate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • eurekaka
  • time-and-fate

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 25, 2021
@time-and-fate
Copy link
Member

Need to add comments for the newly added (c *TopN).Num method.

@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 25, 2021
@eurekaka
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 633b9b2

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 26, 2021
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label May 26, 2021
@winoros
Copy link
Member Author

winoros commented May 26, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1660ece

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 26, 2021
@ti-chi-bot
Copy link
Member

@winoros: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@winoros
Copy link
Member Author

winoros commented May 26, 2021

/run-integration-common-test

@winoros
Copy link
Member Author

winoros commented May 26, 2021

/merge

@dianqihanwangzi
Copy link
Contributor

/run-integration-compatibility-test

1 similar comment
@dianqihanwangzi
Copy link
Contributor

/run-integration-compatibility-test

@dianqihanwangzi
Copy link
Contributor

/run-check_release_note

@winoros
Copy link
Member Author

winoros commented May 26, 2021

/merge

@ti-chi-bot ti-chi-bot merged commit 9b5d92e into pingcap:master May 26, 2021
@winoros winoros deleted the fix-sampling-bug branch May 26, 2021 10:49
@xuyifangreeneyes xuyifangreeneyes mentioned this pull request Feb 20, 2023
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eurekaka eurekaka eurekaka approved these changes

@time-and-fate time-and-fate time-and-fate approved these changes

@qw4990 qw4990 Awaiting requested review from qw4990

Assignees
No one assigned
Labels
component/statistics sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@winoros @ti-chi-bot @time-and-fate @eurekaka @dianqihanwangzi