executor: use helper.GetRegionsTableInfo to get region schema for tidb_hot_regions_history #30500

IcePigZDB · 2021-12-07T14:58:36Z

Signed-off-by: IcePigZDB [email protected]

What problem does this PR solve?

Issue Number: #30518

Problem Summary:
TIDB_HOT_REGIONS_HISTORY need to parse shcema info on TiDB according to the key range of every Region. However, after v5.0 enable-cross-table-merge is default to true, a region may contain multi tables or indics, Previous implemention #27375 tidb/store/helper/Helper.FindTableIndexOfRegion iterate over all tables(first table record and then index ) to check whether it is contained in the region and stop iterate when it find the first table or index. This may result in incomplete result, so use GetTablesInfoWithKeyRange for TIDB_HOT_REGIONS_HISTORY.

Use FilterMemDBs to filter Memory tables who have no corresponding regions.
Use GetRegionsTableInfo instead of FindTableIndexOfRegion.
Extract GetTablesInfoWithKeyRange from GetRegionsTableInfo to avoid repeat call.
Set metrics'(HOT_DEGREE, HOT_DEGREE, KEY_RATE, QUERY_RATE) default value instead of set NULL when they are 0.

Change Preview

Compare the parse result with old and new implmention.
- old result 1
- old result 2
- new result
- selected region's schemas in tikv region status

I list top 10 region in time order for three query and check region's schema with tikv_region_status, new implemention is consistent with tikv_region_status. Complete result is here.

Compared with the old Schema parsing method, the new method also parses the index of the region, it will parse other tables too if there are. Due to the allSchemas' order may different each query, it leads to inconsistent query results.

old result 1

mysql> select * from information_schema.tidb_hot_regions_history where update_time>='2015-04-10 10:10:10' and update_time<='2022-05-10 10:10:10';
+---------------------+--------------------+---------------+---------------------+------------+----------+-----------+----------+---------+------------+-----------+------+------------+------------+----------+------------+
| UPDATE_TIME         | DB_NAME            | TABLE_NAME    | TABLE_ID            | INDEX_NAME | INDEX_ID | REGION_ID | STORE_ID | PEER_ID | IS_LEARNER | IS_LEADER | TYPE | HOT_DEGREE | HOT_DEGREE | KEY_RATE | QUERY_RATE |
+---------------------+--------------------+---------------+---------------------+------------+----------+-----------+----------+---------+------------+-----------+------+------------+------------+----------+------------+
| 2021-12-29 01:45:29 | PERFORMANCE_SCHEMA | GLOBAL_STATUS | 4611686018427397905 | NULL       |     NULL |        83 |        1 |     129 |          0 |         1 | READ |         58 |      82752 |     NULL |        404 |
| 2021-12-29 01:45:29 | PERFORMANCE_SCHEMA | GLOBAL_STATUS | 4611686018427397905 | NULL       |     NULL |        85 |        1 |     166 |          0 |         1 | READ |         58 |      86136 |     NULL |        412 |
| 2021-12-29 01:45:29 | PERFORMANCE_SCHEMA | GLOBAL_STATUS | 4611686018427397905 | NULL       |     NULL |        89 |        1 |      98 |          0 |         1 | READ |         58 |      85657 |     NULL |        410 |
| 2021-12-29 01:45:29 | PERFORMANCE_SCHEMA | GLOBAL_STATUS | 4611686018427397905 | NULL       |     NULL |        95 |        1 |     113 |          0 |         1 | READ |         58 |      85118 |     NULL |        407 |
| 2021-12-29 01:45:29 | PERFORMANCE_SCHEMA | GLOBAL_STATUS | 4611686018427397905 | NULL       |     NULL |       100 |        1 |     170 |          0 |         1 | READ |         58 |      86316 |     NULL |        413 |
| 2021-12-29 01:45:29 | PERFORMANCE_SCHEMA | GLOBAL_STATUS | 4611686018427397905 | NULL       |     NULL |       103 |        1 |     124 |          0 |         1 | READ |         58 |      85624 |     NULL |        410 |
| 2021-12-29 01:45:29 | PERFORMANCE_SCHEMA | GLOBAL_STATUS | 4611686018427397905 | NULL       |     NULL |       110 |        1 |     173 |          0 |         1 | READ |         58 |      85934 |     NULL |        411 |
| 2021-12-29 01:45:29 | PERFORMANCE_SCHEMA | GLOBAL_STATUS | 4611686018427397905 | NULL       |     NULL |       122 |        1 |     162 |          0 |         1 | READ |         58 |      86065 |     NULL |        412 |
| 2021-12-29 01:45:29 | PERFORMANCE_SCHEMA | GLOBAL_STATUS | 4611686018427397905 | NULL       |     NULL |       127 |        1 |     168 |          0 |         1 | READ |         58 |      85529 |     NULL |        409 |
| 2021-12-29 01:45:29 | PERFORMANCE_SCHEMA | GLOBAL_STATUS | 4611686018427397905 | NULL       |     NULL |       140 |        1 |     177 |          0 |         1 | READ |         58 |      85479 |     NULL |        409 |
+---------------------+--------------------+---------------+---------------------+------------+----------+-----------+----------+---------+------------+-----------+------+------------+------------+----------+------------+

old result 2

mysql> select * from information_schema.tidb_hot_regions_history where update_time>='2015-04-10 10:10:10' and update_time<='2022-05-10 10:10:10';
+---------------------+---------+------------+----------+------------+----------+-----------+----------+---------+------------+-----------+------+------------+------------+----------+------------+
| UPDATE_TIME         | DB_NAME | TABLE_NAME | TABLE_ID | INDEX_NAME | INDEX_ID | REGION_ID | STORE_ID | PEER_ID | IS_LEARNER | IS_LEADER | TYPE | HOT_DEGREE | FLOW_BYTES | KEY_RATE | QUERY_RATE |
+---------------------+---------+------------+----------+------------+----------+-----------+----------+---------+------------+-----------+------+------------+------------+----------+------------+
| 2021-12-29 01:45:29 | TEST    | T1000      |      157 | NULL       |     NULL |        83 |        1 |     129 |          0 |         1 | READ |         58 |      82752 |     NULL |        404 |
| 2021-12-29 01:45:29 | TEST    | T1000      |      157 | NULL       |     NULL |        85 |        1 |     166 |          0 |         1 | READ |         58 |      86136 |     NULL |        412 |
| 2021-12-29 01:45:29 | TEST    | T1000      |      157 | NULL       |     NULL |        89 |        1 |      98 |          0 |         1 | READ |         58 |      85657 |     NULL |        410 |
| 2021-12-29 01:45:29 | TEST    | T1000      |      157 | NULL       |     NULL |        95 |        1 |     113 |          0 |         1 | READ |         58 |      85118 |     NULL |        407 |
| 2021-12-29 01:45:29 | TEST    | T1000      |      157 | NULL       |     NULL |       100 |        1 |     170 |          0 |         1 | READ |         58 |      86316 |     NULL |        413 |
| 2021-12-29 01:45:29 | TEST    | T1000      |      157 | NULL       |     NULL |       103 |        1 |     124 |          0 |         1 | READ |         58 |      85624 |     NULL |        410 |
| 2021-12-29 01:45:29 | TEST    | T1000      |      157 | NULL       |     NULL |       110 |        1 |     173 |          0 |         1 | READ |         58 |      85934 |     NULL |        411 |
| 2021-12-29 01:45:29 | TEST    | T1000      |      157 | NULL       |     NULL |       122 |        1 |     162 |          0 |         1 | READ |         58 |      86065 |     NULL |        412 |
| 2021-12-29 01:45:29 | TEST    | T1000      |      157 | NULL       |     NULL |       127 |        1 |     168 |          0 |         1 | READ |         58 |      85529 |     NULL |        409 |
| 2021-12-29 01:45:29 | TEST    | T1000      |      157 | NULL       |     NULL |       140 |        1 |     177 |          0 |         1 | READ |         58 |      85479 |     NULL |        409 |
+---------------------+---------+------------+----------+------------+----------+-----------+----------+---------+------------+-----------+------+------------+------------+----------+------------+

new result

mysql> select * from information_schema.tidb_hot_regions_history where update_time>='2015-04-10 10:10:10' and update_time<='2022-05-10 10:10:10';
+---------------------+---------+------------+----------+------------+----------+-----------+----------+---------+------------+-----------+------+------------+------------+----------+------------+
| UPDATE_TIME         | DB_NAME | TABLE_NAME | TABLE_ID | INDEX_NAME | INDEX_ID | REGION_ID | STORE_ID | PEER_ID | IS_LEARNER | IS_LEADER | TYPE | HOT_DEGREE | FLOW_BYTES | KEY_RATE | QUERY_RATE |
+---------------------+---------+------------+----------+------------+----------+-----------+----------+---------+------------+-----------+------+------------+------------+----------+------------+
| 2021-12-29 01:45:29 | SBTEST  | SBTEST5    |       59 | K_5        |        1 |        83 |        1 |     129 |          0 |         1 | READ |         58 |      82752 |        0 |        404 |
| 2021-12-29 01:45:29 | SBTEST  | SBTEST5    |       59 | NULL       |     NULL |        83 |        1 |     129 |          0 |         1 | READ |         58 |      82752 |        0 |        404 |
| 2021-12-29 01:45:29 | SBTEST  | SBTEST3    |       62 | K_3        |        1 |        85 |        1 |     166 |          0 |         1 | READ |         58 |      86136 |        0 |        412 |
| 2021-12-29 01:45:29 | SBTEST  | SBTEST3    |       62 | NULL       |     NULL |        85 |        1 |     166 |          0 |         1 | READ |         58 |      86136 |        0 |        412 |
| 2021-12-29 01:45:29 | SBTEST  | SBTEST8    |       63 | K_8        |        1 |        89 |        1 |      98 |          0 |         1 | READ |         58 |      85657 |        0 |        410 |
| 2021-12-29 01:45:29 | SBTEST  | SBTEST8    |       63 | NULL       |     NULL |        89 |        1 |      98 |          0 |         1 | READ |         58 |      85657 |        0 |        410 |
| 2021-12-29 01:45:29 | SBTEST  | SBTEST1    |       73 | K_1        |        1 |        95 |        1 |     113 |          0 |         1 | READ |         58 |      85118 |        0 |        407 |
| 2021-12-29 01:45:29 | SBTEST  | SBTEST1    |       73 | NULL       |     NULL |        95 |        1 |     113 |          0 |         1 | READ |         58 |      85118 |        0 |        407 |
| 2021-12-29 01:45:29 | SBTEST  | SBTEST2    |       75 | K_2        |        1 |       100 |        1 |     170 |          0 |         1 | READ |         58 |      86316 |        0 |        413 |
| 2021-12-29 01:45:29 | SBTEST  | SBTEST2    |       75 | NULL       |     NULL |       100 |        1 |     170 |          0 |         1 | READ |         58 |      86316 |        0 |        413 |
| 2021-12-29 01:45:29 | SBTEST  | SBTEST13   |       83 | K_13       |        1 |       103 |        1 |     124 |          0 |         1 | READ |         58 |      85624 |        0 |        410 |
| 2021-12-29 01:45:29 | SBTEST  | SBTEST13   |       83 | NULL       |     NULL |       103 |        1 |     124 |          0 |         1 | READ |         58 |      85624 |        0 |        410 |
| 2021-12-29 01:45:29 | SBTEST  | SBTEST11   |       92 | K_11       |        1 |       110 |        1 |     173 |          0 |         1 | READ |         58 |      85934 |        0 |        411 |
| 2021-12-29 01:45:29 | SBTEST  | SBTEST11   |       92 | NULL       |     NULL |       110 |        1 |     173 |          0 |         1 | READ |         58 |      85934 |        0 |        411 |
| 2021-12-29 01:45:29 | SBTEST  | SBTEST10   |      104 | K_10       |        1 |       122 |        1 |     162 |          0 |         1 | READ |         58 |      86065 |        0 |        412 |
| 2021-12-29 01:45:29 | SBTEST  | SBTEST10   |      104 | NULL       |     NULL |       122 |        1 |     162 |          0 |         1 | READ |         58 |      86065 |        0 |        412 |
| 2021-12-29 01:45:29 | SBTEST  | SBTEST24   |      110 | K_24       |        1 |       127 |        1 |     168 |          0 |         1 | READ |         58 |      85529 |        0 |        409 |
| 2021-12-29 01:45:29 | SBTEST  | SBTEST24   |      110 | NULL       |     NULL |       127 |        1 |     168 |          0 |         1 | READ |         58 |      85529 |        0 |        409 |
| 2021-12-29 01:45:29 | SBTEST  | SBTEST23   |      122 | K_23       |        1 |       140 |        1 |     177 |          0 |         1 | READ |         58 |      85479 |        0 |        409 |
| 2021-12-29 01:45:29 | SBTEST  | SBTEST23   |      122 | NULL       |     NULL |       140 |        1 |     177 |          0 |         1 | READ |         58 |      85479 |        0 |        409 |
+---------------------+---------+------------+----------+------------+----------+-----------+----------+---------+------------+-----------+------+------------+------------+----------+------------+

selected region's schemas in tikv region status

mysql> select * from information_schema.tikv_region_status where region_id in (83,85,89,95,100,103,110,122,127,140) order by region_id;
+-----------+--------------------------------------+--------------------------------------+----------+---------+------------+----------+----------+------------+----------------+---------------+---------------+------------+------------------+------------------+-------------------------+---------------------------+
| REGION_ID | START_KEY                            | END_KEY                              | TABLE_ID | DB_NAME | TABLE_NAME | IS_INDEX | INDEX_ID | INDEX_NAME | EPOCH_CONF_VER | EPOCH_VERSION | WRITTEN_BYTES | READ_BYTES | APPROXIMATE_SIZE | APPROXIMATE_KEYS | REPLICATIONSTATUS_STATE | REPLICATIONSTATUS_STATEID |
+-----------+--------------------------------------+--------------------------------------+----------+---------+------------+----------+----------+------------+----------------+---------------+---------------+------------+------------------+------------------+-------------------------+---------------------------+
|        83 | 7480000000000000FF3B00000000000000F8 | 7480000000000000FF3D00000000000000F8 |       59 | sbtest  | sbtest5    |        1 |        1 | k_5        |             13 |            29 |            30 |          0 |               29 |           205024 | NULL                    |                      NULL |
|        83 | 7480000000000000FF3B00000000000000F8 | 7480000000000000FF3D00000000000000F8 |       59 | sbtest  | sbtest5    |        0 |     NULL | NULL       |             13 |            29 |            30 |          0 |               29 |           205024 | NULL                    |                      NULL |
|        85 | 7480000000000000FF3E00000000000000F8 | 7480000000000000FF3F00000000000000F8 |       62 | sbtest  | sbtest3    |        0 |     NULL | NULL       |             13 |            31 |            30 |          0 |               30 |           201374 | NULL                    |                      NULL |
|        85 | 7480000000000000FF3E00000000000000F8 | 7480000000000000FF3F00000000000000F8 |       62 | sbtest  | sbtest3    |        1 |        1 | k_3        |             13 |            31 |            30 |          0 |               30 |           201374 | NULL                    |                      NULL |
|        89 | 7480000000000000FF3F00000000000000F8 | 7480000000000000FF4400000000000000F8 |       63 | sbtest  | sbtest8    |        0 |     NULL | NULL       |             13 |            31 |            30 |          0 |               29 |           200376 | NULL                    |                      NULL |
|        89 | 7480000000000000FF3F00000000000000F8 | 7480000000000000FF4400000000000000F8 |       63 | sbtest  | sbtest8    |        1 |        1 | k_8        |             13 |            31 |            30 |          0 |               29 |           200376 | NULL                    |                      NULL |
|        95 | 7480000000000000FF4900000000000000F8 | 7480000000000000FF4B00000000000000F8 |       73 | sbtest  | sbtest1    |        0 |     NULL | NULL       |             13 |            34 |            30 |          0 |               30 |           203195 | NULL                    |                      NULL |
|        95 | 7480000000000000FF4900000000000000F8 | 7480000000000000FF4B00000000000000F8 |       73 | sbtest  | sbtest1    |        1 |        1 | k_1        |             13 |            34 |            30 |          0 |               30 |           203195 | NULL                    |                      NULL |
|       100 | 7480000000000000FF4B00000000000000F8 | 7480000000000000FF5300000000000000F8 |       75 | sbtest  | sbtest2    |        1 |        1 | k_2        |             19 |            35 |            30 |          0 |               29 |           200000 | NULL                    |                      NULL |
|       100 | 7480000000000000FF4B00000000000000F8 | 7480000000000000FF5300000000000000F8 |       75 | sbtest  | sbtest2    |        0 |     NULL | NULL       |             19 |            35 |            30 |          0 |               29 |           200000 | NULL                    |                      NULL |
|       103 | 7480000000000000FF5300000000000000F8 | 7480000000000000FF5600000000000000F8 |       83 | sbtest  | sbtest13   |        1 |        1 | k_13       |             19 |            36 |            30 |          0 |               29 |           200000 | NULL                    |                      NULL |
|       103 | 7480000000000000FF5300000000000000F8 | 7480000000000000FF5600000000000000F8 |       83 | sbtest  | sbtest13   |        0 |     NULL | NULL       |             19 |            36 |            30 |          0 |               29 |           200000 | NULL                    |                      NULL |
|       110 | 7480000000000000FF5C00000000000000F8 | 7480000000000000FF5F00000000000000F8 |       92 | sbtest  | sbtest11   |        1 |        1 | k_11       |             19 |            39 |            30 |          0 |               29 |           200000 | NULL                    |                      NULL |
|       110 | 7480000000000000FF5C00000000000000F8 | 7480000000000000FF5F00000000000000F8 |       92 | sbtest  | sbtest11   |        0 |     NULL | NULL       |             19 |            39 |            30 |          0 |               29 |           200000 | NULL                    |                      NULL |
|       122 | 7480000000000000FF6800000000000000F8 | 7480000000000000FF6B00000000000000F8 |      104 | sbtest  | sbtest10   |        1 |        1 | k_10       |             19 |            43 |            30 |          0 |               29 |           200000 | NULL                    |                      NULL |
|       122 | 7480000000000000FF6800000000000000F8 | 7480000000000000FF6B00000000000000F8 |      104 | sbtest  | sbtest10   |        0 |     NULL | NULL       |             19 |            43 |            30 |          0 |               29 |           200000 | NULL                    |                      NULL |
|       127 | 7480000000000000FF6E00000000000000F8 | 7480000000000000FF7100000000000000F8 |      110 | sbtest  | sbtest24   |        1 |        1 | k_24       |             19 |            45 |             0 |          0 |               29 |           200000 | NULL                    |                      NULL |
|       127 | 7480000000000000FF6E00000000000000F8 | 7480000000000000FF7100000000000000F8 |      110 | sbtest  | sbtest24   |        0 |     NULL | NULL       |             19 |            45 |             0 |          0 |               29 |           200000 | NULL                    |                      NULL |
|       140 | 7480000000000000FF7A00000000000000F8 | 7480000000000000FF7D00000000000000F8 |      122 | sbtest  | sbtest23   |        1 |        1 | k_23       |             19 |            49 |             0 |          0 |               29 |           200000 | NULL                    |                      NULL |
|       140 | 7480000000000000FF7A00000000000000F8 | 7480000000000000FF7D00000000000000F8 |      122 | sbtest  | sbtest23   |        0 |     NULL | NULL       |             19 |            49 |             0 |          0 |               29 |           200000 | NULL                    |                      NULL |
+-----------+--------------------------------------+--------------------------------------+----------+---------+------------+----------+----------+------------+----------------+---------------+---------------+------------+------------------+------------------+-------------------------+---------------------------+
20 rows in set (9.88 sec)

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

None

ti-chi-bot · 2021-12-07T14:58:47Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

nolouch
rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

sre-bot · 2021-12-07T14:59:16Z

Please follow PR Title Format:

pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

*: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

IcePigZDB · 2021-12-07T15:02:16Z

/run-all-tests

…Info ref pingcap#30518 Signed-off-by: IcePigZDB <[email protected]>

Signed-off-by: IcePigZDB <[email protected]>

IcePigZDB · 2021-12-15T06:22:35Z

/run-all-tests

executor/memtable_reader.go

executor/memtable_reader_test.go

Signed-off-by: IcePigZDB <[email protected]>

IcePigZDB · 2021-12-27T12:06:54Z

/run-check_dev_2

Signed-off-by: IcePigZDB <[email protected]>

rleungx

The rest LGTM

executor/memtable_reader_test.go

executor/memtable_reader.go

rleungx · 2021-12-28T03:46:29Z

BTW, I find the results of the key rate in your description is always 0.

…r test Signed-off-by: IcePigZDB <[email protected]>

Signed-off-by: IcePigZDB <[email protected]>

IcePigZDB · 2021-12-28T08:52:30Z

check_dev_2

BTW, I find the results of the key rate in your description is always 0.

It's recorded on PD side, I will try to dig it on another day.

IcePigZDB · 2021-12-28T13:37:27Z

/run-unit-test

IcePigZDB · 2021-12-29T02:51:15Z

BTW, I find the results of the key rate in your description is always 0.

Hot regions through sysbench with small table size 100,000 rather than 1000,000.

sysbench --config-file=sb_config oltp_point_select --tables=32 --table-size=100000 prepare

sysbench --config-file=sb_config oltp_point_select --tables=32 --table-size=100000 run
sysbench --config-file=sb_config oltp_update_index --tables=32 --table-size=100000 run
sysbench --config-file=sb_config oltp_read_only --tables=32 --table-size=100000 run

And log the result got from
server/handler.go/PackHistoryHotReadRegions ->
server/handler.go/GetHotReadRegions :

// GetHotReadRegions gets all hot read regions stats.
func (h *Handler) GetHotReadRegions() *statistics.StoreHotPeersInfos {
	c, err := h.GetRaftCluster()
	if err != nil {
		return nil
	}
	return c.GetHotReadRegions()
}

I put the log here, keyrate result is always 0 KeyRate: (float64) 0,.
We check the get code on PD and TiDB, We think it's right, if the hot method is right. Since the queryRate and flowBytes data are normal, I think there is a deeper reason in hotScheduler/ HotCache.

nolouch · 2021-12-29T06:27:34Z

/merge

ti-chi-bot · 2021-12-29T06:27:37Z

@nolouch: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Yisaer · 2021-12-29T08:06:50Z

/merge

ti-chi-bot · 2021-12-29T08:06:54Z

This pull request has been accepted and is ready to merge.

Commit hash: 4688f85

ti-chi-bot · 2021-12-29T08:28:00Z

@IcePigZDB: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 7, 2021

IcePigZDB changed the title ~~Fix hot regions~~ executor: use GetRegionsTableInfo to get region schema for tidb_hot_regions_history Dec 7, 2021

IcePigZDB changed the title ~~executor: use GetRegionsTableInfo to get region schema for tidb_hot_regions_history~~ executor: use helper.GetRegionsTableInfo to get region schema for tidb_hot_regions_history Dec 7, 2021

IcePigZDB force-pushed the fix-hot-regions branch 2 times, most recently from a714f90 to 19e3526 Compare December 8, 2021 02:29

IcePigZDB added 4 commits December 8, 2021 02:44

executor: spilt helper.GetTablesInfoWithKeyRange from GetRegionsTable…

4c26d55

…Info ref pingcap#30518 Signed-off-by: IcePigZDB <[email protected]>

executor: use GetRegionsTableInfo to get region schema

79a6d8c

Signed-off-by: IcePigZDB <[email protected]>

executor: formate

eff3da6

Signed-off-by: IcePigZDB <[email protected]>

helper: adapt to the current usage of dump, infoschema_reader.

0bdc394

Signed-off-by: IcePigZDB <[email protected]>

IcePigZDB force-pushed the fix-hot-regions branch from f798ea1 to 0bdc394 Compare December 8, 2021 02:45

Merge branch 'master' into fix-hot-regions

f6015c1

IcePigZDB mentioned this pull request Dec 8, 2021

executor: use GetRegionsTableInfo to get region schema for tidb_hot_regions_history #30518

Open

2 tasks

executor: filter virtual schema

f203272

Signed-off-by: IcePigZDB <[email protected]>

IcePigZDB force-pushed the fix-hot-regions branch from 47ef1a4 to f203272 Compare December 9, 2021 07:44

IcePigZDB added 2 commits December 10, 2021 03:19

helper: formate FilterMemDBs

76a25e8

Signed-off-by: IcePigZDB <[email protected]>

Merge branch 'master' into fix-hot-regions

a6b2a62

IcePigZDB marked this pull request as ready for review December 10, 2021 06:24

ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 10, 2021

IcePigZDB and others added 6 commits December 13, 2021 03:03

executor: formate tidb_hot_regions_history retriver test

14793db

Signed-off-by: IcePigZDB <[email protected]>

Merge branch 'master' into fix-hot-regions

c2b65e7

executor: check exist before iterate regionsTableInfos

3498de8

Signed-off-by: IcePigZDB <[email protected]>

Merge branch 'master' into fix-hot-regions

4c1099e

Merge branch 'master' into fix-hot-regions

bd2b5d5

Merge branch 'master' into fix-hot-regions

4772d25

nolouch approved these changes Dec 27, 2021

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 27, 2021

rleungx reviewed Dec 27, 2021

View reviewed changes

executor/memtable_reader.go Outdated Show resolved Hide resolved

executor/memtable_reader_test.go Outdated Show resolved Hide resolved

executor/memtable_reader_test.go Outdated Show resolved Hide resolved

executor/memtable_reader_test.go Outdated Show resolved Hide resolved

IcePigZDB and others added 3 commits December 27, 2021 10:26

store/helper: export BytesKeyToHex

6c54c3b

Signed-off-by: IcePigZDB <[email protected]>

address comment

2bc8e18

Signed-off-by: IcePigZDB <[email protected]>

Merge branch 'master' into fix-hot-regions

786c516

store/helper: update comment

7d1039c

Signed-off-by: IcePigZDB <[email protected]>

rleungx approved these changes Dec 28, 2021

View reviewed changes

executor/memtable_reader_test.go Outdated Show resolved Hide resolved

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 28, 2021

JmPotato reviewed Dec 28, 2021

View reviewed changes

executor/memtable_reader.go Outdated Show resolved Hide resolved

IcePigZDB added 2 commits December 28, 2021 08:33

store/helper: export NewTableWithKeyRange and NewIndexWithKeyRange fo…

02385df

…r test Signed-off-by: IcePigZDB <[email protected]>

executor: update tidb_hot_regions_history retriver and it's test

8b54c3d

Signed-off-by: IcePigZDB <[email protected]>

Merge branch 'master' into fix-hot-regions

4688f85

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 29, 2021

ti-chi-bot added 3 commits December 29, 2021 16:07

Merge branch 'master' into fix-hot-regions

5166f9d

Merge branch 'master' into fix-hot-regions

079a5b0

Merge branch 'master' into fix-hot-regions

17eb2b6

ti-chi-bot merged commit c06ecb4 into pingcap:master Dec 29, 2021

IcePigZDB mentioned this pull request Jan 15, 2022

Add virtual table TiDB_HOT_REGIONS_HISTORY #27772

Closed

executor: use helper.GetRegionsTableInfo to get region schema for tidb_hot_regions_history #30500

executor: use helper.GetRegionsTableInfo to get region schema for tidb_hot_regions_history #30500

Uh oh!

Conversation

IcePigZDB commented Dec 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

Change Preview

Check List

Release note

Uh oh!

ti-chi-bot commented Dec 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sre-bot commented Dec 7, 2021

Uh oh!

IcePigZDB commented Dec 7, 2021

Uh oh!

IcePigZDB commented Dec 15, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

IcePigZDB commented Dec 27, 2021

Uh oh!

rleungx left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

rleungx commented Dec 28, 2021

Uh oh!

IcePigZDB commented Dec 28, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

IcePigZDB commented Dec 28, 2021

Uh oh!

IcePigZDB commented Dec 29, 2021

Uh oh!

nolouch commented Dec 29, 2021

Uh oh!

ti-chi-bot commented Dec 29, 2021

Uh oh!

Yisaer commented Dec 29, 2021

Uh oh!

ti-chi-bot commented Dec 29, 2021

Uh oh!

ti-chi-bot commented Dec 29, 2021

Uh oh!

Uh oh!

IcePigZDB commented Dec 7, 2021 •

edited

Loading

ti-chi-bot commented Dec 7, 2021 •

edited

Loading

IcePigZDB commented Dec 28, 2021 •

edited

Loading