-
Notifications
You must be signed in to change notification settings - Fork 6k
*: add explicit partition pruning to index joins (#32007) #32093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
d996cdb
*: add explicit partition pruning to index joins (#32007)
mjonss d177e88
Merge branch 'master' into issue32007
mjonss 5a2dc1f
Reorganized code according to review comment to always call pruning
mjonss 1e8cfe3
refactor prunePartitions to return map instead of list part 1
mjonss 2e09c1a
minor refactor of partitionPruning from returning list to map
mjonss 7ff1f7b
lint fix
mjonss f1024be
added sort to test to make it more stabile
mjonss 1106a81
Cleanup, reverted some too big refactoring
mjonss c16ec51
Merge remote-tracking branch 'pingcap/master' into issue32007
mjonss b7f8943
Updated test to testify
mjonss 03cace2
Merge branch 'master' into issue32007
ti-chi-bot 4e47e0c
Merge branch 'master' into issue32007
ti-chi-bot 8906649
Merge branch 'master' into issue32007
ti-chi-bot 3986546
Merge branch 'master' into issue32007
ti-chi-bot e76e801
Merge branch 'master' into issue32007
ti-chi-bot 91102dc
Merge branch 'master' into issue32007
ti-chi-bot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the partitions are already pruned by
partitionProcessor.convertToIntSlice()
indirectly throughpartitionPruning()
in this code block.Thus, I think the code branches where
partitionPruning()
is not called may have the problem.