Skip to content

ddl: use a param to decide whether exec in distributed mode #41549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 17, 2023
Merged

ddl: use a param to decide whether exec in distributed mode #41549

merged 1 commit into from
Feb 17, 2023

Conversation

tangenta
Copy link
Contributor

@tangenta tangenta commented Feb 17, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #41534

Problem Summary: Previously, TiDB use id == 0 to decide whether to allocate a new backfill context ID for distributed execution. However, it is possible to pass a 0 ID even if the distributed execution is disabled.

What is changed and how it works?

Use a separate parameter to decide whether exec in distributed mode.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 17, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Benjamin2037
  • zimulala

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 17, 2023
@dbsid
Copy link
Contributor

dbsid commented Feb 17, 2023

/run-build-arm64 comment=true

Benjamin2037
Benjamin2037 approved these changes Feb 17, 2023
View reviewed changes
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 17, 2023
@sre-bot
Copy link
Contributor

sre-bot commented Feb 17, 2023

download tidb binary(linux arm64) at http://fileserver.pingcap.net/download/builds/pingcap/test/tidb/a2540932a6352d53f998f763ef6ed4069cf2820d/centos7/tidb-linux-arm64.tar.gz

zimulala
zimulala approved these changes Feb 17, 2023
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 17, 2023
@tangenta
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a254093

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 17, 2023
@ti-chi-bot ti-chi-bot merged commit 69a9dec into pingcap:master Feb 17, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 17, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.6: #41554.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Feb 17, 2023
@tangenta @ti-chi-bot
This is an automated cherry-pick of pingcap#41549
baf1342 
Signed-off-by: ti-chi-bot <[email protected]>
ti-chi-bot added a commit that referenced this pull request Feb 17, 2023
@ti-chi-bot
ddl: use a param to decide whether exec in distributed mode (#41549) (#…
f4ca082 
…41554)

ref #41534
zimulala pushed a commit to zimulala/tidb that referenced this pull request Feb 18, 2023
@ti-chi-bot @zimulala
ddl: use a param to decide whether exec in distributed mode (pingcap#…
1be11cf 
…41549) (pingcap#41554)

ref pingcap#41534
zimulala pushed a commit to zimulala/tidb that referenced this pull request Feb 21, 2023
@ti-chi-bot @zimulala
ddl: use a param to decide whether exec in distributed mode (pingcap#…
6ad865d 
…41549) (pingcap#41554)

ref pingcap#41534
zimulala pushed a commit to zimulala/tidb that referenced this pull request Feb 23, 2023
@ti-chi-bot @zimulala
ddl: use a param to decide whether exec in distributed mode (pingcap#…
1898918 
…41549) (pingcap#41554)

ref pingcap#41534
iosmanthus pushed a commit to iosmanthus/tidb that referenced this pull request Feb 28, 2023
@ti-chi-bot @iosmanthus
ddl: use a param to decide whether exec in distributed mode (pingcap#…
70e23fb 
…41549) (pingcap#41554)

ref pingcap#41534
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimulala zimulala zimulala approved these changes

@Benjamin2037 Benjamin2037 Benjamin2037 approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v6.6 is 17% slower for adding index using tidb_ddl_enable_fast_reorg
6 participants
@tangenta @ti-chi-bot @dbsid @sre-bot @zimulala @Benjamin2037