Skip to content

Conversation

yibin87
Copy link
Contributor

@yibin87 yibin87 commented Mar 27, 2023

What problem does this PR solve?

Issue Number: close #41949

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 27, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • wshwsh12

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 27, 2023
@yibin87
Copy link
Contributor Author

yibin87 commented Mar 27, 2023

/cc @XuHuaiyu @wshwsh12

@ti-chi-bot ti-chi-bot requested review from wshwsh12 and XuHuaiyu March 27, 2023 03:33
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 27, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 27, 2023
@hawkingrei
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 255afd5

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 27, 2023
@yibin87
Copy link
Contributor Author

yibin87 commented Mar 27, 2023

/run-check_dev_2

@yibin87
Copy link
Contributor Author

yibin87 commented Mar 27, 2023

/run-all-tests

@yibin87
Copy link
Contributor Author

yibin87 commented Mar 27, 2023

/test check-dev2

@yibin87
Copy link
Contributor Author

yibin87 commented Mar 27, 2023

/test unit-test

@dveeden
Copy link
Contributor

dveeden commented Mar 27, 2023

The checklist in the PR description says there is a unit test, but I don't see any. I think this is only tested manually, which I think is ok for this PR.

However I do think a release note for this would be good to help users figure out in which version this is fixed when deciding to upgrade etc.

@ti-chi-bot ti-chi-bot merged commit 90657ca into pingcap:master Mar 27, 2023
@dveeden dveeden added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Mar 27, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #42607.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #42838.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

too much logs about [index_merge_reader.go:791] ["worker finish without panic"]
6 participants