-
Notifications
You must be signed in to change notification settings - Fork 6k
Optimizer: do not simplify != NULL #43434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/test check-dev2 |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 0fc9079
|
In response to a cherrypick label: new pull request created to branch |
Issue Number: Ref #43407
Problem Summary:
Predicate simplification merges x != constant1 with x in (list of values). Merge is not correct if constant is NULL.
TiDB follows mysql semantics where x != NULL is always false.
Solution
Do not apply the merge of <> and in list for x != NULL.
Tests
Unit tests
Side effects
None
Documentation
None
Release note