Skip to content

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #45891

What problem does this PR solve?

Issue Number: close #45889

Problem Summary: Revert #45748 and #45646. Batch_point_get for partition table in dynamic mode has many potential problems (see it in #45532), let's ban it now.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-7.3 labels Aug 8, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 8, 2023
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bb7133, lcwangchao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 8, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 8, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-08 07:41:59.656872357 +0000 UTC m=+12084.205888329: ☑️ agreed by lcwangchao.
  • 2023-08-08 07:42:28.704916474 +0000 UTC m=+12113.253932457: ☑️ agreed by bb7133.

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 8, 2023
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-7.3@203d839). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.3     #45902   +/-   ##
================================================
  Coverage               ?   73.2136%           
================================================
  Files                  ?       1266           
  Lines                  ?     390732           
  Branches               ?          0           
================================================
  Hits                   ?     286069           
  Misses                 ?      86304           
  Partials               ?      18359           
Flag Coverage Δ
unit 73.2136% <0.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <0.0000%> (?)
parser 85.0467% <0.0000%> (?)
br 51.9984% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot merged commit 40b72e7 into pingcap:release-7.3 Aug 8, 2023
@Defined2014 Defined2014 deleted the cherry-pick-45891-to-release-7.3 branch August 8, 2023 08:24
@ti-chi-bot ti-chi-bot removed the cherry-pick-approved Cherry pick PR approved by release team. label Aug 9, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-7.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants