ddl: fix DST times for adding index (#47425) #47449
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #47425
What problem does this PR solve?
Issue Number: close #47426, ref #46033
Problem Summary:
I did not consider DST values in #46055. As a result, the timezone names are always ignored. It may cause data inconsistency when TiDB encounters DST values during adding index.
What is changed and how it works?
GetTimeZone()
becauseTimeZoneLocation.GetLocation()
could handle the empty strings properly. Thus, the priority betweentime_zone_name
andtime_zone_offset
is preserved.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.