Skip to content

disttask: fix grafana panel id duplicate #47586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2023
Merged

disttask: fix grafana panel id duplicate #47586

merged 1 commit into from
Oct 13, 2023

Conversation

okJiang
Copy link
Member

@okJiang okJiang commented Oct 12, 2023 •
edited by hawkingrei
Loading

What problem does this PR solve?

Issue Number: close #47585

Problem Summary:

panel id is same

img_v2_1edf7588-ff52-48d8-91b6-748cc35e192g

img_v2_96af828e-16c0-4096-aee0-68d19956528g

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-tests-checked do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Oct 12, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 12, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@okJiang okJiang marked this pull request as ready for review October 12, 2023 09:05
@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Oct 12, 2023
@tiprow
Copy link

tiprow bot commented Oct 12, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@codecov
Copy link

codecov bot commented Oct 12, 2023 •
edited
Loading

Codecov Report

Merging #47586 (0ccf374) into master (14d3cb5) will increase coverage by 0.9936%.
Report is 8 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #47586        +/-   ##
================================================
+ Coverage   71.8879%   72.8816%   +0.9936%     
================================================
  Files          1353       1375        +22     
  Lines        401070     408111      +7041     
================================================
+ Hits         288321     297438      +9117     
+ Misses        93329      91887      -1442     
+ Partials      19420      18786       -634
Flag Coverage Δ
integration 40.6296% <ø> (?)
unit 72.0379% <ø> (+0.1500%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <ø> (ø)
parser 84.7328% <ø> (ø)
br 49.0536% <ø> (-4.3243%) ⬇️

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Oct 12, 2023
GMHDBJD
GMHDBJD approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, GMHDBJD

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 12, 2023
@okJiang
Copy link
Member Author

okJiang commented Oct 12, 2023

/ok-to-test

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 12, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-12 09:15:31.262023137 +0000 UTC m=+1302928.849133274: ☑️ agreed by D3Hunter.
  • 2023-10-12 09:23:59.639091128 +0000 UTC m=+1303437.226201267: ☑️ agreed by GMHDBJD.

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed do-not-merge/needs-tests-checked labels Oct 12, 2023
@hawkingrei
Copy link
Member

/retest

1 similar comment
@hawkingrei
Copy link
Member

/retest

@ti-chi-bot ti-chi-bot bot merged commit f770b7f into pingcap:master Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@D3Hunter D3Hunter D3Hunter approved these changes

@GMHDBJD GMHDBJD GMHDBJD approved these changes

Assignees
No one assigned
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

disttask: grafana panel can't view/edit
4 participants
@okJiang @hawkingrei @D3Hunter @GMHDBJD