Skip to content

Conversation

YangKeao
Copy link
Member

What problem does this PR solve?

Issue Number: close #49680

Problem Summary:

For multi-valued index, we should use the ArrayType to decode the restore data.

What changed and how does it work?

Use the ArrayType rather the direct GetType to decode the restore data. The GetType will give JSON, but we expect the internal type (e.g. unsigned integer, string...).

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Release note

Fix the issue that the compound index of multi-valued index and any other non-binary string cannot be inserted.

@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Dec 22, 2023
@YangKeao YangKeao requested a review from Defined2014 December 22, 2023 07:39
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 22, 2023
@YangKeao YangKeao requested a review from wjhuang2016 December 22, 2023 07:39
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 22, 2023
Copy link

codecov bot commented Dec 22, 2023

Codecov Report

Merging #49720 (e89ddcf) into master (8219934) will increase coverage by 0.3412%.
Report is 46 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #49720        +/-   ##
================================================
+ Coverage   70.9796%   71.3208%   +0.3412%     
================================================
  Files          1368       1428        +60     
  Lines        398699     423203     +24504     
================================================
+ Hits         282995     301832     +18837     
- Misses        95933     102374      +6441     
+ Partials      19771      18997       -774     
Flag Coverage Δ
integration 44.0853% <100.0000%> (?)
unit 70.9795% <ø> (-0.0001%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9663% <ø> (ø)
parser ∅ <ø> (∅)
br 46.6717% <ø> (-6.2109%) ⬇️

@YangKeao YangKeao requested a review from xhebox December 25, 2023 05:41
Copy link

ti-chi-bot bot commented Dec 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 25, 2023
Copy link

ti-chi-bot bot commented Dec 25, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-22 07:52:55.80538216 +0000 UTC m=+1206666.842609087: ☑️ agreed by Defined2014.
  • 2023-12-25 07:01:28.978313758 +0000 UTC m=+1462780.015540669: ☑️ agreed by xhebox.

@ti-chi-bot ti-chi-bot bot merged commit a41527f into pingcap:master Dec 25, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #49761.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 25, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #49762.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

can't insert data using gbk charset
4 participants