-
Notifications
You must be signed in to change notification settings - Fork 6k
rowcodec: use array type to decode index value #49720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Yang Keao <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #49720 +/- ##
================================================
+ Coverage 70.9796% 71.3208% +0.3412%
================================================
Files 1368 1428 +60
Lines 398699 423203 +24504
================================================
+ Hits 282995 301832 +18837
- Misses 95933 102374 +6441
+ Partials 19771 18997 -774
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Defined2014, xhebox The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
What problem does this PR solve?
Issue Number: close #49680
Problem Summary:
For multi-valued index, we should use the
ArrayType
to decode the restore data.What changed and how does it work?
Use the
ArrayType
rather the directGetType
to decode the restore data. TheGetType
will giveJSON
, but we expect the internal type (e.g. unsigned integer, string...).Check List
Tests
Release note