Skip to content

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Feb 20, 2024

What problem does this PR solve?

Issue Number: close #48180

Problem Summary:

What changed and how does it work?

recalculate the threshold of gctuner when ServerMemoryLimit is updated.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

I have tested in the production cluster. When I set ServerMemoryLimit , the GOGC will update.

  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@hawkingrei hawkingrei changed the title *: recalculate the threshold of gctuner when ServerMemoryLimit is upd… *: recalculate the threshold of gctuner when ServerMemoryLimit is updated Feb 20, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 20, 2024
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Merging #51197 (25422db) into master (1fc92b3) will decrease coverage by 15.7448%.
Report is 7 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #51197         +/-   ##
=================================================
- Coverage   70.5999%   54.8551%   -15.7448%     
=================================================
  Files          1467       1576        +109     
  Lines        434849     603225     +168376     
=================================================
+ Hits         307003     330900      +23897     
- Misses       108598     249349     +140751     
- Partials      19248      22976       +3728     
Flag Coverage Δ
integration 36.9427% <100.0000%> (?)
unit 70.4613% <100.0000%> (+0.0624%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 51.4834% <ø> (+5.5876%) ⬆️

@hawkingrei
Copy link
Member Author

/retest

1 similar comment
@hawkingrei
Copy link
Member Author

/retest

@hawkingrei hawkingrei requested a review from XuHuaiyu February 21, 2024 02:06
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 21, 2024
Copy link

ti-chi-bot bot commented Feb 21, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-20 09:35:02.884467822 +0000 UTC m=+349791.632090931: ☑️ agreed by wshwsh12.
  • 2024-02-21 02:38:00.635300873 +0000 UTC m=+411169.382923983: ☑️ agreed by AilinKid.

@easonn7
Copy link

easonn7 commented Feb 21, 2024

/approve

Copy link

ti-chi-bot bot commented Feb 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, easonn7, wshwsh12, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Feb 21, 2024
@hawkingrei
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit e35cf1d into pingcap:master Feb 21, 2024
@hawkingrei hawkingrei deleted the recalculate branch February 21, 2024 04:50
@hawkingrei
Copy link
Member Author

/cherrypick release-7.5
/cherrypick release-7.1
/cherrypick release-6.5

@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-6.5: #51213.

In response to this:

/cherrypick release-7.5
/cherrypick release-7.1
/cherrypick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-7.1: #51214.

In response to this:

/cherrypick release-7.5
/cherrypick release-7.1
/cherrypick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-7.5: #51215.

In response to this:

/cherrypick release-7.5
/cherrypick release-7.1
/cherrypick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

threshold of gctuner need to recalculate when ServerMemoryLimit is updated
6 participants