Skip to content

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Feb 26, 2024

What problem does this PR solve?

Issue Number: ref #45798

Problem Summary: planner: add more test cases for plan cache with generated columns

What changed and how does it work?

planner: add more test cases for plan cache with generated columns

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 26, 2024
Copy link

tiprow bot commented Feb 26, 2024

Hi @qw4990. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 26, 2024
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Merging #51323 (0374ac3) into master (1438892) will decrease coverage by 16.0525%.
Report is 3 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #51323         +/-   ##
=================================================
- Coverage   70.6110%   54.5585%   -16.0525%     
=================================================
  Files          1459       1568        +109     
  Lines        434200     603445     +169245     
=================================================
+ Hits         306593     329231      +22638     
- Misses       108340     251174     +142834     
- Partials      19267      23040       +3773     
Flag Coverage Δ
integration 36.6664% <ø> (?)
unit 70.3151% <ø> (-0.0820%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 51.4264% <ø> (+5.5706%) ⬆️

Copy link

ti-chi-bot bot commented Feb 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [AilinKid,hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 26, 2024
Copy link

ti-chi-bot bot commented Feb 26, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-26 09:25:02.641541091 +0000 UTC m=+867591.389164245: ☑️ agreed by hawkingrei.
  • 2024-02-26 10:05:29.273799646 +0000 UTC m=+870018.021422757: ☑️ agreed by AilinKid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants