*: add super privilege check for some admin commands

[lcwangchao]

What problem does this PR solve?

Issue Number: close #51366

Problem Summary:

What changed and how does it work?

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

[tiprow]

Hi @lcwangchao. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov]

Codecov Report

Merging #51497 (4c0e4e9) into master (62afab3) will increase coverage by 3.2494%.
Report is 84 commits behind head on master.
The diff coverage is 90.9090%.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #51497        +/-   ##
================================================
+ Coverage   70.7337%   73.9831%   +3.2494%     
================================================
  Files          1462       1473        +11     
  Lines        435276     450893     +15617     
================================================
+ Hits         307887     333585     +25698     
+ Misses       108095      97446     -10649     
- Partials      19294      19862       +568     

Flag	Coverage Δ
integration	50.1129% <81.8181%> (?)
unit	71.7408% <72.7272%> (+1.2050%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	53.9957% <ø> (ø)
parser	∅ <ø> (∅)
br	51.1816% <ø> (+5.3490%)	⬆️

[lcwangchao]

/retest

[tiprow]

@lcwangchao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[lcwangchao]

/retest

[tiprow]

@lcwangchao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[songrijie]

Along with the privilege enforcement, we shall include extra dynamic privileges ASAP that allows non-root users share the admin operations. //cc @ljun0712

The given list in this PR looks fine to me.

[ti-chi-bot]

@songrijie: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Along with the privilege enforcement, we shall include extra dynamic privileges ASAP that allows non-root users share the admin operations. //cc @ljun0712

The given list in this PR looks fine to me.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qw4990, songrijie, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [qw4990,tangenta]
• pkg/infoschema/OWNERS [tangenta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-03-11 02:28:30.677461217 +0000 UTC m=+652537.699707605: ☑️ agreed by qw4990.
• 2024-03-11 02:45:14.5264849 +0000 UTC m=+653541.548731287: ☑️ agreed by tangenta.

[lcwangchao]

/hold to add @ljun0712

[ljun0712]

LGTM.
The parts related to SUPER permissions will be adjusted in the future.

[lcwangchao]

/unhold

[lcwangchao]

/retest

[tiprow]

@lcwangchao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[lcwangchao]

/retest

[tiprow]

@lcwangchao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.