global sort: fix forget to close writer when reader has error

[lance6716]

What problem does this PR solve?

Issue Number: close #51508

Problem Summary:

What changed and how does it work?

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  simple

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @lance6716. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[lance6716]

/retest

[tiprow]

@lance6716: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[purelind]

/retest

[tiprow]

@purelind: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov]

Codecov Report

Merging #51509 (0868d65) into master (9d20e33) will increase coverage by 0.3951%.
Report is 7 commits behind head on master.
The diff coverage is 54.5454%.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #51509        +/-   ##
================================================
+ Coverage   72.4220%   72.8171%   +0.3951%     
================================================
  Files          1462       1462                
  Lines        362231     435521     +73290     
================================================
+ Hits         262335     317134     +54799     
- Misses        80527      98429     +17902     
- Partials      19369      19958       +589     

Flag	Coverage Δ
integration	49.0406% <54.5454%> (?)
unit	70.4687% <54.5454%> (-1.8126%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	53.9957% <ø> (-2.3014%)	⬇️
parser	∅ <ø> (∅)
br	51.4508% <54.5454%> (+5.0879%)	⬆️

[Benjamin2037]

Can add UT？

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-03-05 09:00:34.680534987 +0000 UTC m=+157661.702781375: ☑️ agreed by ywqzzy.
• 2024-03-05 10:35:11.487981095 +0000 UTC m=+163338.510227482: ☑️ agreed by wjhuang2016.

[lance6716]

/approve

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, wjhuang2016, ywqzzy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• br/pkg/lightning/OWNERS [lance6716]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment