ddl: forbid alter table partition with global index needed

[jiyfhust]

What problem does this PR solve?

Issue Number: close #51634

Problem Summary:

What changed and how does it work?

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @jiyfhust. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jiyfhust]

/ok-to-test

[codecov]

Codecov Report

Merging #51635 (3c1fe84) into master (15947c1) will increase coverage by 2.1507%.
Report is 64 commits behind head on master.
The diff coverage is 72.4137%.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #51635        +/-   ##
================================================
+ Coverage   70.7427%   72.8934%   +2.1507%     
================================================
  Files          1473       1476         +3     
  Lines        436986     450128     +13142     
================================================
+ Hits         309136     328114     +18978     
+ Misses       108511     101880      -6631     
- Partials      19339      20134       +795     

Flag	Coverage Δ
integration	50.0024% <72.4137%> (?)
unit	70.4842% <37.9310%> (-0.0680%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	53.9957% <ø> (ø)
parser	∅ <ø> (∅)
br	51.1017% <ø> (+5.2321%)	⬆️

[jiyfhust]

/cc @Defined2014 @mjonss @tiancaiamao

[mjonss]

Very good catch!

[Benjamin2037]

LGTM

[mjonss]

/hold

[mjonss]

I found a new case that should be fixed by this PR,
ALTER TABLE t PARTITION BY ... on an already partitioned table, must be checked as well, not only non-partitioned tables.

[mjonss]

Suggested change

	// Only non-partition table to partition table need to check global index.
	if piOld.Type == model.PartitionTypeNone {

I think it needs to be checked for all types, since this is still accepted:

create table t4 (a int primary key, b int) partition by hash(a) partitions 3;
alter table t4 partition by hash(b) partitions 3;

[jiyfhust]

Yes, you are right. Updated 6ab2ba1.

[mjonss]

Thanks for the updated PR, LGTM.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, Defined2014, mjonss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Benjamin2037,Defined2014,mjonss]
• pkg/ddl/OWNERS [Benjamin2037]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-03-12 10:27:59.874966626 +0000 UTC m=+767706.897213012: ☑️ agreed by mjonss.
• 2024-03-12 13:26:11.588397368 +0000 UTC m=+778398.610643756: ☑️ agreed by Benjamin2037.
• 2024-03-12 13:46:32.23090198 +0000 UTC m=+779619.253148369: ✖️🔁 reset by mjonss.
• 2024-03-13 11:45:58.429650773 +0000 UTC m=+858785.451897159: ☑️ agreed by mjonss.
• 2024-03-15 06:39:54.019456691 +0000 UTC m=+1013221.041703079: ☑️ agreed by Defined2014.