statistics: only analyze one index at a time #51785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hi-rustin <[email protected]>
Signed-off-by: hi-rustin <[email protected]>
ti-chi-bot
bot
added
do-not-merge/needs-triage-completed
release-note-none
Signed-off-by: hi-rustin <[email protected]>
0xPoe
commented
Mar 14, 2024
| @@ -204,6 +204,7 @@ func (j *DynamicPartitionedTableAnalysisJob) analyzePartitionIndexes( | |||
| ) { | |||
| analyzePartitionBatchSize := int(variable.AutoAnalyzePartitionBatchSize.Load()) | |||
|
|
|||
| OnlyPickOneIndex: | |||
There was a problem hiding this comment.
The reasons I use a label here are:
- I can't easily retrieve the first kv from a map, so I prefer to use a for loop.
- If I directly return from the inner loop, I will get an SA4004 warning from the static check.
So I think a named label would help.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #51785 +/- ##
================================================
+ Coverage 70.7335% 72.8345% +2.1009%
================================================
Files 1476 1476
Lines 437532 437758 +226
================================================
+ Hits 309482 318839 +9357
+ Misses 108659 98910 -9749
- Partials 19391 20009 +618
Flags with carried forward coverage won't be shown. Click here to find out more.
|
hawkingrei
approved these changes
Mar 14, 2024
ti-chi-bot
bot
added
approved
needs-1-more-lgtm
winoros
approved these changes
Mar 14, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #51775
Problem Summary:
We are analyzing the same table multiple times because when an index is analyzed in TiDB, it also analyzes other indexes and columns.
What changed and how does it work?
Only one index should be analyzed. Multiple indexes are stored to track the total analyzed indexes, even if only one is triggered.
You can check the tests to see what is the correct behavior.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.