Skip to content

Conversation

Defined2014
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #51723

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Mar 20, 2024
@Defined2014 Defined2014 changed the title planner: generate correct plan when copType = TiDB with keepOrder planner: generate correct plan when copType = TiDB with keepOrder = true Mar 20, 2024
@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 20, 2024
Copy link

tiprow bot commented Mar 20, 2024

Hi @Defined2014. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Defined2014 Defined2014 changed the title planner: generate correct plan when copType = TiDB with keepOrder = true planner: generate correct plan when use TiDB cop with KeepOrder Mar 20, 2024
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 76.19048% with 15 lines in your changes missing coverage. Please review.

Project coverage is 74.1528%. Comparing base (a6cd5e7) to head (3054a6c).
Report is 52 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #51922        +/-   ##
================================================
+ Coverage   73.0959%   74.1528%   +1.0568%     
================================================
  Files          1676       1679         +3     
  Lines        463577     479337     +15760     
================================================
+ Hits         338856     355442     +16586     
+ Misses       103888     102670      -1218     
- Partials      20833      21225       +392     
Flag Coverage Δ
integration 43.3003% <71.4285%> (?)
unit 72.6294% <58.7301%> (+0.3573%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 45.4545% <ø> (-0.3101%) ⬇️

@Defined2014
Copy link
Contributor Author

/test check-dev2

Copy link

tiprow bot commented Mar 20, 2024

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Defined2014
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Mar 20, 2024

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Defined2014 Defined2014 changed the title planner: generate correct plan when use TiDB cop with KeepOrder planner: generate correct plan when scan tidb related cluster table with KeepOrder Mar 20, 2024
@Defined2014 Defined2014 changed the title planner: generate correct plan when scan tidb related cluster table with KeepOrder planner: correct plan when scan tidb related cluster table with KeepOrder Mar 20, 2024
@Defined2014
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Mar 20, 2024

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 20, 2024
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 20, 2024
@Defined2014 Defined2014 requested review from winoros and AilinKid March 21, 2024 02:00
@winoros
Copy link
Member

winoros commented Mar 21, 2024

/hold for a while, there might be some memory issue if we call plan.Clone()

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 21, 2024
@Defined2014 Defined2014 deleted the fix-51723 branch March 29, 2024 06:17
@Defined2014 Defined2014 restored the fix-51723 branch April 10, 2024 09:19
@Defined2014 Defined2014 reopened this Apr 10, 2024
@ti-chi-bot ti-chi-bot bot added the sig/planner SIG: Planner label Apr 10, 2024
Copy link

ti-chi-bot bot commented Apr 12, 2024

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 12, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 9, 2025
Copy link

ti-chi-bot bot commented Jan 9, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-09 07:46:44.324702028 +0000 UTC m=+426147.613533734: ☑️ agreed by AilinKid.
  • 2025-01-09 14:06:57.068450016 +0000 UTC m=+448960.357281720: ☑️ agreed by winoros.

@ti-chi-bot ti-chi-bot bot merged commit 5301602 into pingcap:master Jan 9, 2025
24 checks passed
@Defined2014 Defined2014 added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. labels Jan 10, 2025
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jan 10, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #58846.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jan 10, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #58847.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #58848.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jan 10, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #58849.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jan 10, 2025
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jan 10, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #58850.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return out of order results for query cluster_slow_query with order by
4 participants