Skip to content

Conversation

imalasong
Copy link
Contributor

@imalasong imalasong commented Apr 1, 2024

What problem does this PR solve?

PHONY is set on one line, which makes it cumbersome and difficult to maintain as more functions are added. And I found that many functions were not set to enter PHONY

Now set your own PHONY for each function

The changes are as follows:

1、delete tazel (not used)
2、modify: These are all set on the top line of the corresponding function:help all clean test server dev benchkv benchraw check checklist parser tidy ddltest build_br build_lightning build_lightning-ctl build_dumpling ut bazel_build bazel_prepare bazel_test check-file-perm check-bazel-prepare bazel_lint precheck
3、addition: docker、buildsucc、linux...etc

Issue Number: close #52259

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-tests-checked size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Apr 1, 2024
Copy link

ti-chi-bot bot commented Apr 1, 2024

Hi @imalasong. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

tiprow bot commented Apr 1, 2024

Hi @imalasong. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@imalasong
Copy link
Contributor Author

The content is the same as # 52258, there was an issue with merging the previous PR code. Specially submit a new PR

@jiyfhust
Copy link
Contributor

jiyfhust commented Apr 1, 2024

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Apr 1, 2024
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

Merging #52293 (044765f) into master (d971a6d) will increase coverage by 1.1861%.
The diff coverage is n/a.

❗ Current head 044765f differs from pull request most recent head b104393. Consider uploading reports for the commit b104393 to get more accurate results

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #52293        +/-   ##
================================================
+ Coverage   72.0983%   73.2844%   +1.1861%     
================================================
  Files          1467       1468         +1     
  Lines        426605     432546      +5941     
================================================
+ Hits         307575     316989      +9414     
+ Misses        99807      95733      -4074     
- Partials      19223      19824       +601     
Flag Coverage Δ
integration 48.7086% <ø> (?)
unit 70.9587% <ø> (-0.0171%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 41.3109% <ø> (+0.7500%) ⬆️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 1, 2024
Copy link

ti-chi-bot bot commented Apr 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hawkingrei,lance6716]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 2, 2024
Copy link

ti-chi-bot bot commented Apr 2, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-01 14:34:06.05890591 +0000 UTC m=+281707.586446456: ☑️ agreed by lance6716.
  • 2024-04-02 03:40:39.665590362 +0000 UTC m=+328901.193130908: ☑️ agreed by hawkingrei.

@ti-chi-bot ti-chi-bot bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed do-not-merge/needs-tests-checked labels Apr 2, 2024
@ti-chi-bot ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 2, 2024
@ti-chi-bot ti-chi-bot bot merged commit 798edbc into pingcap:master Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make error
4 participants