ddl: fix unstable test TestCreateDropCreateTable (#50076)

[ti-chi-bot]

This is an automated cherry-pick of #50076

What problem does this PR solve?

Issue Number: close #50061

Problem Summary:

There is a gap between runningJobs.remove() and next runningJobs.add(). If getJob() is invoked during this gap, DDL worker may execute the second create table job first.

What changed and how does it work?

This PR distinguishes the concept between "processing" jobs and "unfinished" jobs:

• Processing jobs: activatly running by a DDL worker.
• Unfinished jobs: the jobs whose state is NOT synced, done, or rollback done.

For checkRunnable(), we should use "unfinished jobs" to determine the dependency.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tangenta, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/ddl/OWNERS [tangenta,wjhuang2016]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-05-28 12:04:23.504875695 +0000 UTC m=+2778017.262011263: ☑️ agreed by tangenta.
• 2024-05-28 12:04:54.5527974 +0000 UTC m=+2778048.309932970: ☑️ agreed by wjhuang2016.

[codecov]

Codecov Report

Attention: Patch coverage is 88.63636% with 5 lines in your changes are missing coverage. Please review.

Please upload report for BASE (release-7.5@ff05c7a). Learn more about missing BASE report.

Additional details and impacted files

@@               Coverage Diff                @@
##             release-7.5     #53635   +/-   ##
================================================
  Coverage               ?   72.0292%           
================================================
  Files                  ?       1411           
  Lines                  ?     410618           
  Branches               ?          0           
================================================
  Hits                   ?     295765           
  Misses                 ?      94983           
  Partials               ?      19870           

Flag	Coverage Δ
unit	72.0292% <88.6363%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	53.9913% <0.0000%> (?)
parser	∅ <0.0000%> (?)
br	53.4681% <0.0000%> (?)