Skip to content

expression: fix the wrong behavior of conv function #53681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 30, 2024
Merged

expression: fix the wrong behavior of conv function #53681

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54780b3
fixup
qw4990 May 30, 2024
3cc35c4
fixup
qw4990 May 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion pkg/expression/builtin_math.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1189,7 +1189,11 @@ func (b *builtinConvSig) evalString(ctx EvalContext, row chunk.Row) (res string,
switch x := b.args[0].(type) {
case *Constant:
if x.Value.Kind() == types.KindBinaryLiteral {
str = x.Value.GetBinaryLiteral().ToBitLiteralString(true)
datum, err := x.Eval(ctx, row)
if err != nil {
return "", false, err
}
str = datum.GetBinaryLiteral().ToBitLiteralString(true)
}
case *ScalarFunction:
if x.FuncName.L == ast.Cast {
Expand Down
14 changes: 14 additions & 0 deletions pkg/planner/core/plan_cache_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1253,6 +1253,20 @@ func TestPlanCacheBindingIgnore(t *testing.T) {
tk.MustQuery(`select @@last_plan_from_cache`).Check(testkit.Rows("0"))
}

func TestIssue53505(t *testing.T) {
store := testkit.CreateMockStore(t)
tk := testkit.NewTestKit(t, store)
tk.MustExec("use test")
tk.MustExec(`create table t (v varchar(16))`)
tk.MustExec(`insert into t values ('156')`)
tk.MustExec(`prepare stmt7 from 'select * from t where v = conv(?, 16, 8)'`)
tk.MustExec(`set @arg=0x6E`)
tk.MustQuery(`execute stmt7 using @arg`).Check(testkit.Rows("156"))
tk.MustQuery(`execute stmt7 using @arg`).Check(testkit.Rows("156"))
tk.MustExec(`set @arg=0x70`)
tk.MustQuery(`execute stmt7 using @arg`).Check(testkit.Rows()) // empty
}

func TestBuiltinFuncFlen(t *testing.T) {
// same as TestIssue45378 and TestIssue45253
store := testkit.CreateMockStore(t)
Expand Down