ddl: record the used indexID for global-sort reorg

[lance6716]

What problem does this PR solve?

Issue Number: ref #53677

Problem Summary:

What changed and how does it work?

This is a follow-up of PR #53632 to resolve a TODO. Before this PR, we don't know which index does a ingest subtask belong, so we can't generate the index name of "duplicate entry" error.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @lance6716. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

Attention: Patch coverage is 84.90566% with 8 lines in your changes missing coverage. Please review.

Project coverage is 56.6467%. Comparing base (e785887) to head (4233484).
Report is 20 commits behind head on master.

Additional details and impacted files

@@                Coverage Diff                @@
##             master     #53975         +/-   ##
=================================================
- Coverage   72.5412%   56.6467%   -15.8946%     
=================================================
  Files          1508       1637        +129     
  Lines        431815     613462     +181647     
=================================================
+ Hits         313244     347506      +34262     
- Misses        99179     242713     +143534     
- Partials      19392      23243       +3851     

Flag	Coverage Δ
integration	37.2876% <84.9056%> (?)
unit	72.3792% <16.9811%> (+0.8490%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.9656% <ø> (ø)
parser	∅ <ø> (∅)
br	50.5892% <ø> (+8.3773%)	⬆️

[D3Hunter]

rest lgtm

[D3Hunter]

maybe we should write in doc that we don't support using global sort during upgrade, so we don't need to maintain this in-compatibility

[Frank945946]

From a user perspective, it would be best if we could accommodate this case and not block users from upgrading. Otherwise, a lot of restrictions would hinder the promotion and usage of this feature. Therefore, I suggest we optimize internally and avoid blocking upgrades.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [D3Hunter,tangenta]
• pkg/ddl/OWNERS [tangenta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-06-14 02:58:31.829404205 +0000 UTC m=+692665.882716130: ☑️ agreed by D3Hunter.
• 2024-06-14 08:55:23.367931389 +0000 UTC m=+714077.421243313: ☑️ agreed by tangenta.

[lance6716]

/retest

[tiprow]

@lance6716: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.