-
Notifications
You must be signed in to change notification settings - Fork 6k
ddl: enlarge general ddl worker pool #54041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Skipping CI for Draft Pull Request. |
Hi @D3Hunter. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #54041 +/- ##
=================================================
- Coverage 74.5821% 55.9129% -18.6692%
=================================================
Files 1516 1636 +120
Lines 360770 605266 +244496
=================================================
+ Hits 269070 338422 +69352
- Misses 72225 243624 +171399
- Partials 19475 23220 +3745
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/hold some test depends on 1 worker, need fix them |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/unhold |
[LGTM Timeline notifier]Timeline:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance6716, tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: ref #53246
Problem Summary:
What changed and how does it work?
Check List
Tests
using create table/db as a general ddl example, and use infoschema v1:
on 8.1: create 100K tables(under same database)/databases on owner on 1pd/3tidb/3tikv using 10 threads takes 3h49m/8h27m
after this pr(there're other pr that contribute to the speedup, see linked pr in the issue): same config, takes 50m/2h42m
No need to test
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.