Skip to content

Conversation

D3Hunter
Copy link
Contributor

@D3Hunter D3Hunter commented Jun 17, 2024

What problem does this PR solve?

Issue Number: ref #53246

Problem Summary:

What changed and how does it work?

  • enlarge general ddl worker pool to 10 which is the same as reorg worker pool size

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

using create table/db as a general ddl example, and use infoschema v1:

  • on 8.1: create 100K tables(under same database)/databases on owner on 1pd/3tidb/3tikv using 10 threads takes 3h49m/8h27m

  • after this pr(there're other pr that contribute to the speedup, see linked pr in the issue): same config, takes 50m/2h42m

  • No need to test

    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Copy link

ti-chi-bot bot commented Jun 17, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/invalid-title do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 17, 2024
Copy link

tiprow bot commented Jun 17, 2024

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@D3Hunter D3Hunter changed the title ddl: enlarge general ddl worker pool to 10 ddl: enlarge general ddl worker pool Jun 17, 2024
@D3Hunter D3Hunter marked this pull request as ready for review June 17, 2024 11:06
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 17, 2024
@D3Hunter D3Hunter mentioned this pull request Jun 17, 2024
18 tasks
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.9129%. Comparing base (26d1096) to head (a57b9a4).
Report is 2 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #54041         +/-   ##
=================================================
- Coverage   74.5821%   55.9129%   -18.6692%     
=================================================
  Files          1516       1636        +120     
  Lines        360770     605266     +244496     
=================================================
+ Hits         269070     338422      +69352     
- Misses        72225     243624     +171399     
- Partials      19475      23220       +3745     
Flag Coverage Δ
integration 37.1652% <90.0000%> (?)
unit 71.5331% <100.0000%> (-1.9444%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <ø> (-2.2339%) ⬇️
parser ∅ <ø> (∅)
br 50.6594% <ø> (+6.6582%) ⬆️

@D3Hunter
Copy link
Contributor Author

/hold

some test depends on 1 worker, need fix them

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 17, 2024
Benjamin2037
Benjamin2037 previously approved these changes Jun 17, 2024
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 17, 2024
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 17, 2024
@ti-chi-bot ti-chi-bot bot removed the approved label Jun 17, 2024
@D3Hunter
Copy link
Contributor Author

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 17, 2024
@D3Hunter D3Hunter requested review from lance6716 and tangenta June 18, 2024 02:15
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 18, 2024
Copy link

ti-chi-bot bot commented Jun 18, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-17 12:07:20.738655519 +0000 UTC m=+30167.224144343: ☑️ agreed by Benjamin2037.
  • 2024-06-18 02:17:22.994951209 +0000 UTC m=+81169.480440041: ☑️ agreed by lance6716.

Copy link

ti-chi-bot bot commented Jun 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jun 18, 2024
@ti-chi-bot ti-chi-bot bot merged commit 8f56847 into pingcap:master Jun 18, 2024
@D3Hunter D3Hunter deleted the general-ddl-con branch June 18, 2024 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants