Skip to content

Conversation

ei-sugimoto
Copy link
Contributor

@ei-sugimoto ei-sugimoto commented Jun 19, 2024

What problem does this PR solve?

Issue Number: close #54115

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. labels Jun 19, 2024
@sre-bot
Copy link
Contributor

sre-bot commented Jun 19, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

ti-chi-bot bot commented Jun 19, 2024

Welcome @ei-sugimoto!

It looks like this is your first PR to pingcap/tidb 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/tidb. 😃

@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Jun 19, 2024
Copy link

ti-chi-bot bot commented Jun 19, 2024

Hi @ei-sugimoto. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

tiprow bot commented Jun 19, 2024

Hi @ei-sugimoto. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lance6716
Copy link
Contributor

/ok-to-test

@ei-sugimoto Hi, please sign CLA as bot said

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Jun 20, 2024
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.2796%. Comparing base (74a7173) to head (f0a83fb).

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #54116         +/-   ##
=================================================
- Coverage   72.9019%   55.2796%   -17.6223%     
=================================================
  Files          1520       1641        +121     
  Lines        434902     605579     +170677     
=================================================
+ Hits         317052     334762      +17710     
- Misses        98339     248360     +150021     
- Partials      19511      22457       +2946     
Flag Coverage Δ
integration 35.7006% <ø> (?)
unit 71.7811% <ø> (-0.1160%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <ø> (ø)
parser ∅ <ø> (∅)
br 46.5405% <ø> (+0.3646%) ⬆️

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 20, 2024
@lance6716
Copy link
Contributor

Here's the error from CI

Please run make bazel_prepare to update .bazel files, or just apply the following git diff (run git apply - and paste following contents):

diff --git a/pkg/domain/BUILD.bazel b/pkg/domain/BUILD.bazel
index 8b4f659c35..abead8a809 100644
--- a/pkg/domain/BUILD.bazel
+++ b/pkg/domain/BUILD.bazel
@@ -132,7 +132,7 @@ go_test(
     ],
     embed = [":domain"],
     flaky = True,
-    shard_count = 27,
+    shard_count = 28,
     deps = [
         "//pkg/config",
         "//pkg/ddl",

@ei-sugimoto
Copy link
Contributor Author

@hawkingrei Thanks, Review!!
@lance6716 Thanks, Review and I sign CLA .

Copy link

ti-chi-bot bot commented Jun 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 23, 2024
Copy link

ti-chi-bot bot commented Jun 23, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-20 02:42:31.841453478 +0000 UTC m=+255478.326942311: ☑️ agreed by hawkingrei.
  • 2024-06-23 00:20:50.452508741 +0000 UTC m=+506176.937997569: ☑️ agreed by lance6716.

@ti-chi-bot ti-chi-bot bot merged commit 74accb3 into pingcap:master Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add negative testing for SendTask()
4 participants