-
Notifications
You must be signed in to change notification settings - Fork 6k
domain: add negative testing for SendTask() #54116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
domain: add negative testing for SendTask() #54116
Conversation
Welcome @ei-sugimoto! |
Hi @ei-sugimoto. Thanks for your PR. I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @ei-sugimoto. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test @ei-sugimoto Hi, please sign CLA as bot said |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #54116 +/- ##
=================================================
- Coverage 72.9019% 55.2796% -17.6223%
=================================================
Files 1520 1641 +121
Lines 434902 605579 +170677
=================================================
+ Hits 317052 334762 +17710
- Misses 98339 248360 +150021
- Partials 19511 22457 +2946
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Here's the error from CI
diff --git a/pkg/domain/BUILD.bazel b/pkg/domain/BUILD.bazel
index 8b4f659c35..abead8a809 100644
--- a/pkg/domain/BUILD.bazel
+++ b/pkg/domain/BUILD.bazel
@@ -132,7 +132,7 @@ go_test(
],
embed = [":domain"],
flaky = True,
- shard_count = 27,
+ shard_count = 28,
deps = [
"//pkg/config",
"//pkg/ddl", |
@hawkingrei Thanks, Review!! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, lance6716 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: close #54115
Problem Summary:
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.