-
Notifications
You must be signed in to change notification settings - Fork 6k
executor: setup mem tracker for CTE correctly #54208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: setup mem tracker for CTE correctly #54208
Conversation
Signed-off-by: guo-shaoge <[email protected]>
Hi @guo-shaoge. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: guo-shaoge <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #54208 +/- ##
=================================================
- Coverage 72.8487% 55.5135% -17.3353%
=================================================
Files 1524 1644 +120
Lines 435759 607162 +171403
=================================================
+ Hits 317445 337057 +19612
- Misses 98715 246938 +148223
- Partials 19599 23167 +3568
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: guo-shaoge <[email protected]>
…em_tracker Signed-off-by: guo-shaoge <[email protected]>
Signed-off-by: guo-shaoge <[email protected]>
/retest |
@guo-shaoge: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: guo-shaoge <[email protected]>
pkg/util/chunk/row_container.go
Outdated
@@ -340,6 +340,7 @@ func (c *RowContainer) Close() (err error) { | |||
c.actionSpill.cond.Broadcast() | |||
c.actionSpill.SetFinished() | |||
} | |||
// todo unbind action |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will unbind action for all executors later
Signed-off-by: guo-shaoge <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wshwsh12, XuHuaiyu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #54181
Problem Summary: As issue said
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.