Skip to content

Conversation

tiancaiamao
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #54702

Problem Summary:

What changed and how does it work?

The test tests temporary table does not visit network. But when infoschema v2 is used, table by name also visit network.
So the test is not appliabl to infoschema v2, just skip it in that case.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 18, 2024
Copy link

tiprow bot commented Jul 18, 2024

Hi @tiancaiamao. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 18, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 18, 2024
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.8547%. Comparing base (a48a4a2) to head (ea68540).
Report is 4 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #54707         +/-   ##
=================================================
- Coverage   72.6973%   55.8547%   -16.8427%     
=================================================
  Files          1551       1667        +116     
  Lines        437184     605215     +168031     
=================================================
+ Hits         317821     338041      +20220     
- Misses        99756     244108     +144352     
- Partials      19607      23066       +3459     
Flag Coverage Δ
integration 35.9317% <ø> (?)
unit 71.6959% <ø> (-0.0138%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <ø> (ø)
parser ∅ <ø> (∅)
br 52.5301% <ø> (+6.6896%) ⬆️

@hawkingrei hawkingrei requested a review from Defined2014 July 18, 2024 06:10
Copy link

ti-chi-bot bot commented Jul 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 18, 2024
Copy link

ti-chi-bot bot commented Jul 18, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-18 05:57:05.094973789 +0000 UTC m=+506247.085915260: ☑️ agreed by hawkingrei.
  • 2024-07-18 06:22:33.623961396 +0000 UTC m=+507775.614902866: ☑️ agreed by xhebox.

@ti-chi-bot ti-chi-bot bot merged commit 34dfcfa into pingcap:master Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestPointGetForTemporaryTable timed out after 5m0s
3 participants