-
Notifications
You must be signed in to change notification settings - Fork 6k
*: Update client-go to fix fair locking panic when executing a query after OOM kill in a transaction #54740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: Update client-go to fix fair locking panic when executing a query after OOM kill in a transaction #54740
Conversation
Signed-off-by: MyonKeminta <[email protected]>
Hi @MyonKeminta. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/retest |
@MyonKeminta: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.5 #54740 +/- ##
================================================
Coverage ? 72.0536%
================================================
Files ? 1412
Lines ? 411835
Branches ? 0
================================================
Hits ? 296742
Misses ? 95228
Partials ? 19865
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfzjywxk, you06 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is a reopened PR of #54574 which cherry-picks #53698
What problem does this PR solve?
Issue Number: close #53540 #54375
Problem Summary:
What changed and how does it work?
Update client-go to fix the problem that when query OOM kill happens in a transaction, the next query in the transaction may encounter panic when starting fair locking.
Also includes tikv/client-go#1381 (ref: #54375)
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.