Skip to content

Conversation

RidRisR
Copy link
Contributor

@RidRisR RidRisR commented Aug 23, 2024

What problem does this PR solve?

Issue Number: close #55273

Problem Summary:
log-backup: secrets may be directly logging to log when --send-credentials-to-tikv=false not set during starting log backup

What changed and how does it work?

Added a wrap of the storage info and redact ak/sk, now the logging woud not print them directly.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.
截屏2024-08-23 17 40 01

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Added a wrap of the storage info and redact ak/sk, now the logging woud not print them directly.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Aug 23, 2024
Copy link

tiprow bot commented Aug 23, 2024

Hi @RidRisR. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Aug 23, 2024
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.6153%. Comparing base (99180a8) to head (7c3e52b).
Report is 49 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #55622        +/-   ##
================================================
+ Coverage   72.9575%   75.6153%   +2.6578%     
================================================
  Files          1577       1585         +8     
  Lines        440885     452322     +11437     
================================================
+ Hits         321659     342025     +20366     
+ Misses        99480      89572      -9908     
- Partials      19746      20725       +979     
Flag Coverage Δ
integration 50.4932% <100.0000%> (?)
unit 72.0507% <100.0000%> (+0.0182%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (ø)
parser ∅ <ø> (∅)
br 60.2277% <100.0000%> (+14.2817%) ⬆️

@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 23, 2024
@RidRisR RidRisR requested review from Leavrth and BornChanger August 26, 2024 07:24
@YuJuncen
Copy link
Contributor

compilepkg: nogo: errors found by nogo during build-time code analysis:

pkg/util/redact/redact.go:240:7: unused-receiver: method receiver 't' is not referenced in method's body, consider removing or renaming it as _ (revive)

pkg/util/redact/redact.go:236:6: exported: exported type TaskInfoRedacted should have comment or be unexported (revive)

Would you fix those linter problems?

@RidRisR
Copy link
Contributor Author

RidRisR commented Aug 26, 2024

/test unit-test

@RidRisR
Copy link
Contributor Author

RidRisR commented Aug 26, 2024

/test build

Copy link

tiprow bot commented Aug 26, 2024

@RidRisR: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

tiprow bot commented Aug 26, 2024

@RidRisR: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@RidRisR
Copy link
Contributor Author

RidRisR commented Aug 27, 2024

/test pull-br-integration-test

Copy link

tiprow bot commented Aug 27, 2024

@RidRisR: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 28, 2024
Copy link

ti-chi-bot bot commented Aug 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Leavrth, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 28, 2024
Copy link

ti-chi-bot bot commented Aug 28, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-28 02:26:35.18819917 +0000 UTC m=+923590.322649288: ☑️ agreed by Leavrth.
  • 2024-08-28 02:44:23.588631313 +0000 UTC m=+924658.723081434: ☑️ agreed by YuJuncen.

@RidRisR
Copy link
Contributor Author

RidRisR commented Aug 28, 2024

/test unit-test

Copy link

tiprow bot commented Aug 28, 2024

@RidRisR: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit 51ffa22 into pingcap:master Aug 28, 2024
32 of 36 checks passed
@BornChanger BornChanger added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels Aug 30, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Aug 30, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #55777.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #55778.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #55779.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Aug 30, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Aug 30, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #55780.

ti-chi-bot bot pushed a commit that referenced this pull request Sep 5, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Sep 27, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Nov 11, 2024
@RidRisR RidRisR deleted the redact branch November 26, 2024 08:22
ti-chi-bot bot pushed a commit that referenced this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

log-backup: secrets may be directly logging to log when --send-credentials-to-tikv=false not set during starting log backup
5 participants