Skip to content

Conversation

D3Hunter
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #55658

Problem Summary:

What changed and how does it work?

due to info cache v2, the task/subtask id might bump to 30000+

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 26, 2024
Copy link

tiprow bot commented Aug 26, 2024

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 26, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 26, 2024
Copy link

ti-chi-bot bot commented Aug 26, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-26 11:50:03.7116862 +0000 UTC m=+784598.846136320: ☑️ agreed by wjhuang2016.
  • 2024-08-26 11:57:07.171588343 +0000 UTC m=+785022.306038465: ☑️ agreed by lance6716.

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.7611%. Comparing base (4eeeef8) to head (469ce42).
Report is 2 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #55668        +/-   ##
================================================
+ Coverage   72.9214%   74.7611%   +1.8396%     
================================================
  Files          1581       1581                
  Lines        442336     442374        +38     
================================================
+ Hits         322558     330724      +8166     
+ Misses        99970      91369      -8601     
- Partials      19808      20281       +473     
Flag Coverage Δ
integration 48.9742% <ø> (?)
unit 71.8581% <ø> (-0.1430%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (ø)
parser ∅ <ø> (∅)
br 52.0039% <ø> (+6.7247%) ⬆️

Copy link

ti-chi-bot bot commented Aug 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joccau, lance6716, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 44f100f into pingcap:master Aug 26, 2024
23 checks passed
@D3Hunter D3Hunter deleted the fix-flaky55658 branch August 26, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flaky test TestParallelCancel
4 participants