-
Notifications
You must be signed in to change notification settings - Fork 6k
*: set default shard_row_id_bits and pre_split_regions for all tables #55717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #55717 +/- ##
=================================================
- Coverage 72.8489% 58.3319% -14.5171%
=================================================
Files 1604 1756 +152
Lines 445733 643839 +198106
=================================================
+ Hits 324712 375564 +50852
- Misses 101000 243773 +142773
- Partials 20021 24502 +4481
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/test check-dev |
@jackysp: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/retest-required |
/hold new feature need confirm from PM |
The default values are the same as in prior versions, and it supports setting the values at the session level. LGTM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[LGTM Timeline notifier]Timeline:
|
/hold |
@jackysp I just hold this pr and let PM Frank help open an FD for this issue,sync with you! |
@Frank945946: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Jack Yu <[email protected]>
@yudongusa PTAL, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and please don't forget modifying TiDB document.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Benjamin2037, Frank945946, tangenta, yudongusa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
What problem does this PR solve?
Issue Number: close #55716
Problem Summary:
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.