Skip to content

planner: fix incorrect estRows with global index and json column #55842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 6, 2024
Merged

planner: fix incorrect estRows with global index and json column #55842

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7c03967
planner: fix incorrect estRows and result with global index
hawkingrei Sep 4, 2024
21d10e0
tmp0904
hawkingrei Sep 4, 2024
31316a0
tmp0904
hawkingrei Sep 4, 2024
bb5f725
tmp0904
hawkingrei Sep 4, 2024
f6e5762
tmp0904
hawkingrei Sep 4, 2024
8ce4fbf
test
hawkingrei Sep 6, 2024
d143c07
test
hawkingrei Sep 6, 2024
4fe087b
test
hawkingrei Sep 6, 2024
4382573
test
hawkingrei Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion pkg/statistics/table.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -774,7 +774,11 @@ func (coll *HistColl) GetScaledRealtimeAndModifyCnt(idxStats *Index) (realtimeCn
if analyzeRowCount <= 0 {
return coll.RealtimeCount, coll.ModifyCount
}
scale := idxStats.TotalRowCount() / analyzeRowCount
idxTotalRowCount := idxStats.TotalRowCount()
if idxTotalRowCount <= 0 {
return coll.RealtimeCount, coll.ModifyCount
}
scale := idxTotalRowCount / analyzeRowCount
return int64(float64(coll.RealtimeCount) * scale), int64(float64(coll.ModifyCount) * scale)
}

Expand Down
47 changes: 47 additions & 0 deletions tests/integrationtest/r/planner/core/issuetest/planner_issue.result
View file
Open in desktop

Large diffs are not rendered by default.

44 changes: 43 additions & 1 deletion tests/integrationtest/t/planner/core/issuetest/planner_issue.test
View file
Open in desktop

Large diffs are not rendered by default.