Skip to content

Conversation

xzhangxian1008
Copy link
Contributor

What problem does this PR solve?

cherry-pick of #48032

Issue Number: close #46475

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved labels Sep 10, 2024
Copy link

tiprow bot commented Sep 10, 2024

Hi @xzhangxian1008. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@xzhangxian1008
Copy link
Contributor Author

/cc @windtalker @wshwsh12

@ti-chi-bot ti-chi-bot bot requested review from windtalker and wshwsh12 September 10, 2024 07:42
@xzhangxian1008 xzhangxian1008 changed the title expression: fix the return type of coalesce when arg type is DATE | tidb-test=pr/xxxx expression: fix the return type of coalesce when arg type is DATE | tidb-test=pr/2387 Sep 10, 2024
@xzhangxian1008
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Sep 10, 2024

@xzhangxian1008: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@wuhuizuo
Copy link
Contributor

please ignore the two aborted CI statuses:

image

Maybe they are caused by prow bug.

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 81.21212% with 31 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-7.1@d61bc29). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.1     #55978   +/-   ##
================================================
  Coverage               ?   73.4861%           
================================================
  Files                  ?       1211           
  Lines                  ?     380820           
  Branches               ?          0           
================================================
  Hits                   ?     279850           
  Misses                 ?      83128           
  Partials               ?      17842           

Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 11, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Sep 11, 2024
Copy link

ti-chi-bot bot commented Sep 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: windtalker, wshwsh12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [windtalker,wshwsh12]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 11, 2024
Copy link

ti-chi-bot bot commented Sep 11, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-11 00:58:18.769535976 +0000 UTC m=+404368.509959916: ☑️ agreed by windtalker.
  • 2024-09-11 02:04:21.163850193 +0000 UTC m=+408330.904274132: ☑️ agreed by wshwsh12.

@xzhangxian1008
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Sep 11, 2024

@xzhangxian1008: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit 87569e8 into pingcap:release-7.1 Sep 11, 2024
12 of 14 checks passed
@xzhangxian1008 xzhangxian1008 deleted the cp-48032-7.1 branch September 11, 2024 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants