Skip to content

Conversation

tangenta
Copy link
Contributor

@tangenta tangenta commented Sep 20, 2024

What problem does this PR solve?

Issue Number: close #55917

Problem Summary:

The distributed lock was acquired successfully, but it failed to be released. When DDL retried in the next round, it stuck at acquiring the same distributed lock.

What changed and how does it work?

Similar to existing mechanisms of DDL owner key or server info key, add a lease for the distributed lock

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 20, 2024
Copy link

tiprow bot commented Sep 20, 2024

Hi @tangenta. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 46.87500% with 17 lines in your changes missing coverage. Please review.

Project coverage is 76.3397%. Comparing base (e87affb) to head (5f4d438).
Report is 920 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #56184        +/-   ##
================================================
+ Coverage   73.4116%   76.3397%   +2.9281%     
================================================
  Files          1601       1626        +25     
  Lines        444010     456817     +12807     
================================================
+ Hits         325955     348733     +22778     
+ Misses        98086      86622     -11464     
- Partials      19969      21462      +1493     
Flag Coverage Δ
integration 52.2520% <46.8750%> (?)
unit 72.6682% <34.3750%> (+0.1924%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 65.4286% <ø> (+19.5424%) ⬆️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 20, 2024
Copy link
Contributor

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 24, 2024
@tangenta tangenta requested a review from lance6716 September 24, 2024 08:24
Copy link
Contributor

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

Copy link

ti-chi-bot bot commented Sep 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 24, 2024
Copy link

ti-chi-bot bot commented Sep 24, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-20 08:34:57.26843402 +0000 UTC m=+1209367.008857959: ☑️ agreed by wjhuang2016.
  • 2024-09-24 08:45:21.27530744 +0000 UTC m=+1555591.015731378: ☑️ agreed by lance6716.

@wjhuang2016
Copy link
Member

/retest

@ti-chi-bot ti-chi-bot bot merged commit 42c6e24 into pingcap:master Sep 24, 2024
25 checks passed
@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. and removed needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels Feb 6, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #59265.
But this PR has conflicts, please resolve them!

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Feb 6, 2025
tangenta added a commit to ti-chi-bot/tidb that referenced this pull request Jul 15, 2025
ti-chi-bot bot pushed a commit that referenced this pull request Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add index blocked after injection pd leader io delay
4 participants