Skip to content

planner: make converge index merge path feel the prefer tiflash hint #56227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 25, 2024
Merged

planner: make converge index merge path feel the prefer tiflash hint #56227

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6031650
.
AilinKid Sep 23, 2024
045e7ff
.
AilinKid Sep 23, 2024
b319490
.
AilinKid Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions pkg/executor/test/tiflashtest/tiflash_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2117,3 +2117,35 @@ func TestMppTableReaderCacheForSingleSQL(t *testing.T) {
require.Equal(t, tc.expectMissNum, missNum.Load())
}
}

func TestIndexMergeCarePreferTiflash(t *testing.T) {
store := testkit.CreateMockStore(t, withMockTiFlash(1))
tk := testkit.NewTestKit(t, store)
tk.MustExec("use test")

tk.MustExec("drop table if exists t")
tk.MustExec("CREATE TABLE `t` (" +
"`i` bigint(20) NOT NULL, " +
"`w` varchar(32) NOT NULL," +
"`l` varchar(32) NOT NULL," +
"`a` tinyint(4) NOT NULL DEFAULT '0'," +
"`m` int(11) NOT NULL DEFAULT '0'," +
"`s` int(11) NOT NULL DEFAULT '0'," +
"PRIMARY KEY (`i`) /*T![clustered_index] NONCLUSTERED */," +
"KEY `idx_win_user_site_code` (`w`,`m`)," +
"KEY `idx_lose_user_site_code` (`l`,`m`)," +
"KEY `idx_win_site_code_status` (`w`,`a`)," +
"KEY `idx_lose_site_code_status` (`l`,`a`)" +
")")
tk.MustExec("alter table t set tiflash replica 1")
tb := external.GetTableByName(t, tk, "test", "t")
err := domain.GetDomain(tk.Session()).DDLExecutor().UpdateTableReplicaInfo(tk.Session(), tb.Meta().ID, true)
require.NoError(t, err)
tk.MustQuery("explain format=\"brief\" SELECT" +
" /*+ read_from_storage(tiflash[a]) */ a.i FROM t a WHERE a.s = 0 AND a.a NOT IN (-1, 0) AND m >= 1726910326 AND m <= 1726910391 AND ( a.w IN ('1123') OR a.l IN ('1123'))").Check(
testkit.Rows("TableReader 0.00 root MppVersion: 2, data:ExchangeSender",
"└─ExchangeSender 0.00 mpp[tiflash] ExchangeType: PassThrough",
" └─Projection 0.00 mpp[tiflash] test.t.i",
" └─Selection 0.00 mpp[tiflash] ge(test.t.m, 1726910326), le(test.t.m, 1726910391), not(in(test.t.a, -1, 0)), or(eq(test.t.w, \"1123\"), eq(test.t.l, \"1123\"))",
" └─TableFullScan 10.00 mpp[tiflash] table:a pushed down filter:eq(test.t.s, 0), keep order:false, stats:pseudo"))
}
6 changes: 6 additions & 0 deletions pkg/planner/core/find_best_task.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1356,6 +1356,10 @@ func findBestTask4DS(ds *DataSource, prop *property.PhysicalProperty, planCounte
for _, candidate := range candidates {
path := candidate.path
if path.PartialIndexPaths != nil {
// prefer tiflash, while current table path is tikv, skip it.
if ds.PreferStoreType&h.PreferTiFlash != 0 && path.StoreType == kv.TiKV {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when we step into here, we can ensure that

  • tiflash is existed (replica set is checked)
  • whether tiflash path can be generated successfully or not, not sure here, just keep the same logic from L1498

future work: we can sort the candidate paths according to the user's preferred hints or variables, then gen them first, if we do, output their preferred path, on the condition that the preferred path can be generated successfully. IF failed, then try next, inferior paths

continue
}
idxMergeTask, err := convertToIndexMergeScan(ds, prop, candidate, opt)
if err != nil {
return nil, 0, err
Expand Down Expand Up @@ -1491,9 +1495,11 @@ func findBestTask4DS(ds *DataSource, prop *property.PhysicalProperty, planCounte
}
}
if path.IsTablePath() {
// prefer tiflash, while current table path is tikv, skip it.
if ds.PreferStoreType&h.PreferTiFlash != 0 && path.StoreType == kv.TiKV {
continue
}
// prefer tikv, while current table path is tiflash, skip it.
if ds.PreferStoreType&h.PreferTiKV != 0 && path.StoreType == kv.TiFlash {
continue
}
Expand Down