Skip to content

Conversation

lcwangchao
Copy link
Collaborator

@lcwangchao lcwangchao commented Oct 9, 2024

What problem does this PR solve?

Issue Number: close #56511

What changed and how does it work?

force to kill the TTL scan sql when cancelling TTL job/task

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

TTL: force to kill the TTL scan sql when cancelling TTL job/task

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 9, 2024
Copy link

tiprow bot commented Oct 9, 2024

Hi @lcwangchao. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 57.1784%. Comparing base (1eb0c8c) to head (037f74a).
Report is 140 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #56518         +/-   ##
=================================================
- Coverage   73.3698%   57.1784%   -16.1915%     
=================================================
  Files          1626       1776        +150     
  Lines        448852     642830     +193978     
=================================================
+ Hits         329322     367560      +38238     
- Misses        99364     250787     +151423     
- Partials      20166      24483       +4317     
Flag Coverage Δ
integration 38.6551% <0.0000%> (?)
unit 73.1433% <91.6666%> (+0.6801%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 52.4870% <ø> (+6.9101%) ⬆️

@lcwangchao lcwangchao changed the title ttl: force to kill scan sql when cancelling TTL job/task ttl: force to kill SQL in scan task when cancelling TTL job/task Oct 9, 2024
@lcwangchao lcwangchao force-pushed the canceljobkillscansql branch from 1fa38b7 to eabceb1 Compare October 9, 2024 16:01
@lcwangchao lcwangchao force-pushed the canceljobkillscansql branch from eabceb1 to 037f74a Compare October 10, 2024 00:33
@lcwangchao lcwangchao requested review from bb7133 and YangKeao October 10, 2024 01:28
@lcwangchao lcwangchao changed the title ttl: force to kill SQL in scan task when cancelling TTL job/task ttl: force to kill SQL in scan task when canceling TTL job/task Oct 10, 2024
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 10, 2024
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Oct 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bb7133, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 10, 2024
Copy link

ti-chi-bot bot commented Oct 10, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-10 07:14:50.064585104 +0000 UTC m=+1116645.484798108: ☑️ agreed by YangKeao.
  • 2024-10-10 17:17:13.039286285 +0000 UTC m=+1152788.459499296: ☑️ agreed by bb7133.

@lcwangchao
Copy link
Collaborator Author

/retest

Copy link

tiprow bot commented Oct 11, 2024

@lcwangchao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lcwangchao
Copy link
Collaborator Author

/retest

Copy link

tiprow bot commented Oct 11, 2024

@lcwangchao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hawkingrei
Copy link
Member

/retest

1 similar comment
@lcwangchao
Copy link
Collaborator Author

/retest

Copy link

tiprow bot commented Oct 11, 2024

@lcwangchao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit e68c26a into pingcap:master Oct 11, 2024
23 checks passed
@lcwangchao lcwangchao deleted the canceljobkillscansql branch October 11, 2024 07:41
@lcwangchao lcwangchao added needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels Oct 11, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #56576.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Oct 11, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #56577.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Oct 11, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #56578.

@lcwangchao lcwangchao added needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. labels Oct 29, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.4: #56959.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: cannot checkout release-8.5: error checking out release-8.5: exit status 1. output: error: pathspec 'release-8.5' did not match any file(s) known to git

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TTL should force to kill the scan SQL when TTL job cancels
5 participants