Skip to content

Conversation

YangKeao
Copy link
Member

What problem does this PR solve?

Issue Number: close #56563

What changed and how does it work?

Add tests for using both IMPORT INTO statement and the foreign key. It's expected that IMPORT INTO will always ignore the foreign key checks.

TODO: confirm that the behavior is as expected, and modify the document.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Oct 11, 2024
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 11, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 11, 2024
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.7111%. Comparing base (ffcfb5e) to head (5b5f714).
Report is 51 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #56568         +/-   ##
=================================================
- Coverage   73.3704%   56.7111%   -16.6594%     
=================================================
  Files          1626       1753        +127     
  Lines        448978     638085     +189107     
=================================================
+ Hits         329417     361865      +32448     
- Misses        99381     252141     +152760     
- Partials      20180      24079       +3899     
Flag Coverage Δ
integration 37.0454% <ø> (?)
unit 72.8010% <ø> (+0.3207%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 52.3345% <ø> (+6.7608%) ⬆️

@lance6716 lance6716 requested a review from D3Hunter October 14, 2024 03:40
Copy link

ti-chi-bot bot commented Oct 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 14, 2024
Copy link

ti-chi-bot bot commented Oct 14, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-11 07:23:48.969942543 +0000 UTC m=+1203584.390155539: ☑️ agreed by lance6716.
  • 2024-10-14 03:52:37.312217604 +0000 UTC m=+243154.461127436: ☑️ agreed by D3Hunter.

@D3Hunter
Copy link
Contributor

/hold

please unhold after fix comments

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 14, 2024
@YangKeao YangKeao force-pushed the test-fk-with-import-into branch from 44ff4e3 to 5b5f714 Compare October 14, 2024 07:27
@YangKeao
Copy link
Member Author

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 14, 2024
@YangKeao
Copy link
Member Author

/retest

1 similar comment
@YangKeao
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit a45a181 into pingcap:master Oct 14, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add test for IMPORT INTO with Foreign Key.
3 participants