Skip to content

Conversation

0xPoe
Copy link
Member

@0xPoe 0xPoe commented Oct 18, 2024

What problem does this PR solve?

Issue Number: ref #55722

Problem Summary:

What changed and how does it work?

  1. Created the ddl notifier table.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 18, 2024
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 51.16279% with 21 lines in your changes missing coverage. Please review.

Project coverage is 55.0199%. Comparing base (e13bfeb) to head (3521564).
Report is 3 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #56723         +/-   ##
=================================================
- Coverage   73.3262%   55.0199%   -18.3064%     
=================================================
  Files          1630       1779        +149     
  Lines        450312     636973     +186661     
=================================================
+ Hits         330197     350462      +20265     
- Misses        99833     263407     +163574     
- Partials      20282      23104       +2822     
Flag Coverage Δ
integration 34.7649% <51.1627%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 46.0067% <ø> (+0.4179%) ⬆️

@0xPoe 0xPoe force-pushed the rustin-patch-ddl-notifier branch 2 times, most recently from 17ab8a5 to 5a80432 Compare October 18, 2024 07:35
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 18, 2024
@0xPoe 0xPoe force-pushed the rustin-patch-ddl-notifier branch 3 times, most recently from 3a797ac to 8726fb7 Compare October 18, 2024 08:43
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 18, 2024
@0xPoe 0xPoe force-pushed the rustin-patch-ddl-notifier branch from a56c919 to 2aca3a4 Compare October 19, 2024 12:37
@0xPoe
Copy link
Member Author

0xPoe commented Oct 19, 2024

/retest

@0xPoe 0xPoe force-pushed the rustin-patch-ddl-notifier branch 10 times, most recently from 10dba4a to 9e6a0cd Compare October 20, 2024 07:49
@0xPoe
Copy link
Member Author

0xPoe commented Oct 20, 2024

/retest

@0xPoe 0xPoe force-pushed the rustin-patch-ddl-notifier branch 2 times, most recently from 3687667 to eebd1d1 Compare October 20, 2024 09:01
@0xPoe 0xPoe force-pushed the rustin-patch-ddl-notifier branch from eebd1d1 to 194567d Compare October 20, 2024 09:06
@0xPoe
Copy link
Member Author

0xPoe commented Oct 20, 2024

/retest

4 similar comments
@0xPoe
Copy link
Member Author

0xPoe commented Oct 20, 2024

/retest

@0xPoe
Copy link
Member Author

0xPoe commented Oct 20, 2024

/retest

@0xPoe
Copy link
Member Author

0xPoe commented Oct 20, 2024

/retest

@0xPoe
Copy link
Member Author

0xPoe commented Oct 20, 2024

/retest

Copy link

ti-chi-bot bot commented Oct 20, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from rustin170506 and additionally assign wjhuang2016 for approval(Please ensuring that each of them provides their approval before proceeding). For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@0xPoe 0xPoe force-pushed the rustin-patch-ddl-notifier branch from 2914d4d to f96b715 Compare October 20, 2024 14:20
Copy link

tiprow bot commented Oct 20, 2024

@Rustin170506: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fast_test_tiprow 3521564 link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

ti-chi-bot bot commented Oct 20, 2024

@Rustin170506: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-unit-test-ddlv1 3521564 link true /test pull-unit-test-ddlv1
idc-jenkins-ci-tidb/unit-test 3521564 link true /test unit-test
idc-jenkins-ci-tidb/check_dev_2 3521564 link true /test check-dev2
pull-lightning-integration-test 3521564 link true /test pull-lightning-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant