Skip to content

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #56545

What problem does this PR solve?

Issue Number: close #56544

Problem Summary:

What changed and how does it work?

Upgrade from old version tidb, infoschema v2 should not be used.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

See the steps described in the issue.

  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-8.4 labels Oct 21, 2024
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.4@2205f33). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.4     #56738   +/-   ##
================================================
  Coverage               ?   56.3203%           
================================================
  Files                  ?       1751           
  Lines                  ?     628384           
  Branches               ?          0           
================================================
  Hits                   ?     353908           
  Misses                 ?     250498           
  Partials               ?      23978           
Flag Coverage Δ
integration 36.9218% <0.0000%> (?)
unit 72.5144% <40.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 52.3837% <0.0000%> (?)

@tiancaiamao
Copy link
Contributor

/retest

@tiancaiamao
Copy link
Contributor

/test check-dev

Copy link

tiprow bot commented Oct 21, 2024

@tiancaiamao: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test check-dev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 21, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 22, 2024
Copy link

ti-chi-bot bot commented Oct 22, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-21 11:48:26.25580732 +0000 UTC m=+265306.952597950: ☑️ agreed by GMHDBJD.
  • 2024-10-22 02:16:59.126162303 +0000 UTC m=+317419.822952913: ☑️ agreed by tiancaiamao.

Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@yudongusa yudongusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Oct 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, GMHDBJD, tiancaiamao, yudongusa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Oct 22, 2024
@ti-chi-bot ti-chi-bot bot merged commit d123c9f into pingcap:release-8.4 Oct 22, 2024
34 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-8.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants