ddl: fix some limitation of primary key + global index

[Defined2014]

What problem does this PR solve?

Issue Number: close #56804

Problem Summary: If the primary index mentioned is a global index, then it should be a non-clustered index.

What changed and how does it work?

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @Defined2014. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.2825%. Comparing base (5cbe855) to head (72f2674).
Report is 9 commits behind head on master.

Additional details and impacted files

@@                Coverage Diff                @@
##             master     #56808         +/-   ##
=================================================
- Coverage   73.3016%   57.2825%   -16.0191%     
=================================================
  Files          1636       1786        +150     
  Lines        453237     643171     +189934     
=================================================
+ Hits         332230     368425      +36195     
- Misses       100665     249501     +148836     
- Partials      20342      25245       +4903     

Flag	Coverage Δ
integration	39.3695% <100.0000%> (?)
unit	72.5045% <14.2857%> (+0.0048%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.9478% <ø> (ø)
parser	∅ <ø> (∅)
br	63.1443% <ø> (+17.1403%)	⬆️

[mjonss]

LGTM, but I would prefer not to implicitly change the [NON]CLUSTERED PK depending on GLOBAL option, rather have the implicit default as is, and fail instead of having GLOBAL change the type implicitly.

[mjonss]

So we are changing the implicit default of CLUSTERED PK depending if we have a global index or not?
I would prefer to always have that explicit, and fail if normally it would be CLUSTERED, but GLOBAL is given.

[Defined2014]

Updated, @mjonss

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjonss, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mjonss,tangenta]
• pkg/ddl/OWNERS [tangenta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-10-25 06:08:32.605427521 +0000 UTC m=+590513.302218124: ☑️ agreed by tangenta.
• 2024-10-25 08:39:36.011571533 +0000 UTC m=+599576.708362140: ☑️ agreed by mjonss.

[Defined2014]

/retest

[tiprow]

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.