executor: fix hash join v2 bug that mistakenly think the join has other condition

[windtalker]

What problem does this PR solve?

Issue Number: close #56825

Problem Summary:

The root cause is in HashJoinV2, it use hCtx.OtherCondition != nil to check if it has other condition. However, sometimes, hCtx.OtherCondition can be an empty slice.

What changed and how does it work?

This pr makes sure that OtherCondition/BuildFilter/ProbeFilter must be either nil or a non-empty slice.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @windtalker. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

Attention: Patch coverage is 91.30435% with 2 lines in your changes missing coverage. Please review.

Project coverage is 56.3200%. Comparing base (3f0514e) to head (6972469).
Report is 2 commits behind head on master.

Additional details and impacted files

@@                Coverage Diff                @@
##             master     #56834         +/-   ##
=================================================
- Coverage   73.3565%   56.3200%   -17.0366%     
=================================================
  Files          1636       1761        +125     
  Lines        453398     632310     +178912     
=================================================
+ Hits         332597     356117      +23520     
- Misses       100440     252163     +151723     
- Partials      20361      24030       +3669     

Flag	Coverage Δ
integration	37.1296% <91.3043%> (?)
unit	72.5513% <91.3043%> (-0.0198%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.9478% <ø> (ø)
parser	∅ <ø> (∅)
br	52.6949% <ø> (+6.6623%)	⬆️

[xzhangxian1008]

LGTM

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XuHuaiyu, xzhangxian1008

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [XuHuaiyu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-10-25 08:03:27.97474097 +0000 UTC m=+597408.671531579: ☑️ agreed by XuHuaiyu.
• 2024-10-25 08:10:00.25409552 +0000 UTC m=+597800.950886147: ☑️ agreed by xzhangxian1008.