Skip to content

Conversation

nolouch
Copy link
Member

@nolouch nolouch commented Oct 28, 2024

What problem does this PR solve?

Issue Number: close #56916

Problem Summary:

The query may be blocking after identifying a runaway query with a cooldown action.

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 28, 2024
@nolouch nolouch requested review from glorv and crazycs520 October 28, 2024 13:46
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 28, 2024
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.3018%. Comparing base (cc4e5a0) to head (8f4852f).
Report is 6 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #56920         +/-   ##
=================================================
- Coverage   73.2812%   56.3018%   -16.9794%     
=================================================
  Files          1638       1764        +126     
  Lines        453733     634175     +180442     
=================================================
+ Hits         332501     357052      +24551     
- Misses       100849     253047     +152198     
- Partials      20383      24076       +3693     
Flag Coverage Δ
integration 37.0184% <71.4285%> (?)
unit 72.4994% <100.0000%> (+0.0137%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 52.6501% <ø> (+6.6384%) ⬆️

@nolouch
Copy link
Member Author

nolouch commented Oct 28, 2024

/retest-required

Signed-off-by: nolouch <[email protected]>
@nolouch
Copy link
Member Author

nolouch commented Oct 28, 2024

/retest-required

1 similar comment
@nolouch
Copy link
Member Author

nolouch commented Oct 28, 2024

/retest-required

ch = taskCh
} else {
ch := taskCh
if i >= it.concurrency && smallTaskCh != nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: this change seems unnecessary as smallTaskCh can only be not nil when smallTaskConcurrency > 0

Copy link

ti-chi-bot bot commented Oct 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crazycs520, glorv

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 29, 2024
Copy link

ti-chi-bot bot commented Oct 29, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-28 13:49:16.535507062 +0000 UTC m=+271269.374662603: ☑️ agreed by crazycs520.
  • 2024-10-29 02:12:34.132704306 +0000 UTC m=+315866.971859851: ☑️ agreed by glorv.

@nolouch nolouch added the needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. label Oct 29, 2024
@ti-chi-bot ti-chi-bot bot merged commit 11f86a8 into pingcap:master Oct 29, 2024
23 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.4: #56931.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The query may be blocking after identifying a runaway query with a cooldown action.
4 participants