-
Notifications
You must be signed in to change notification settings - Fork 6k
copr: fix the issue about runaway index lookup query blocking #56920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: nolouch <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #56920 +/- ##
=================================================
- Coverage 73.2812% 56.3018% -16.9794%
=================================================
Files 1638 1764 +126
Lines 453733 634175 +180442
=================================================
+ Hits 332501 357052 +24551
- Misses 100849 253047 +152198
- Partials 20383 24076 +3693
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest-required |
Signed-off-by: nolouch <[email protected]>
8370efb
to
8f4852f
Compare
/retest-required |
1 similar comment
/retest-required |
ch = taskCh | ||
} else { | ||
ch := taskCh | ||
if i >= it.concurrency && smallTaskCh != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: this change seems unnecessary as smallTaskCh can only be not nil when smallTaskConcurrency > 0
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crazycs520, glorv The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #56916
Problem Summary:
The query may be blocking after identifying a runaway query with a cooldown action.
What changed and how does it work?
Check List
Tests
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.