Skip to content

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #57095

What problem does this PR solve?

Issue Number: close #57094

Problem Summary:

The test TestDeleteIgnoreWithFK is flaky because of the order of warnings.

What changed and how does it work?

Sort the warnings before the assertion.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Nov 4, 2024
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 4, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 4, 2024
Copy link

ti-chi-bot bot commented Nov 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Defined2014,hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 4, 2024
Copy link

ti-chi-bot bot commented Nov 4, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-04 06:28:48.179729931 +0000 UTC m=+849641.018885471: ☑️ agreed by Defined2014.
  • 2024-11-04 06:31:22.395897778 +0000 UTC m=+849795.235053321: ☑️ agreed by hawkingrei.

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.3862%. Comparing base (999befe) to head (7cc9074).
Report is 1 commits behind head on release-8.5.

Additional details and impacted files
@@                 Coverage Diff                  @@
##           release-8.5     #57097         +/-   ##
====================================================
- Coverage      73.2006%   56.3862%   -16.8144%     
====================================================
  Files             1652       1778        +126     
  Lines           456093     634995     +178902     
====================================================
+ Hits            333863     358050      +24187     
- Misses          101707     252720     +151013     
- Partials         20523      24225       +3702     
Flag Coverage Δ
integration 37.1804% <ø> (?)
unit 72.5533% <ø> (+0.0789%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 52.6738% <ø> (+6.6764%) ⬆️

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Nov 4, 2024
@ti-chi-bot ti-chi-bot bot merged commit cca7be9 into pingcap:release-8.5 Nov 4, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants